Skip to content

Commit c5e1c8b

Browse files
fix: Inconsistent directives value between Default and OPCache groups (#9476)
* fix: Inconsistent directives value between default and OPCache groups * improve remark message * Apply suggestions from code review Co-authored-by: John Paul E. Balandan, CPA <[email protected]> --------- Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
1 parent 1cfe68c commit c5e1c8b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

system/Security/CheckPhpIni.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ public static function checkIni(?string $argument = null): array
135135
'date.timezone' => ['recommended' => 'UTC'],
136136
'mbstring.language' => ['recommended' => 'neutral'],
137137
'opcache.enable' => ['recommended' => '1'],
138-
'opcache.enable_cli' => ['recommended' => '1'],
138+
'opcache.enable_cli' => ['recommended' => '0', 'remark' => 'Enable when you are using queues or running repetitive CLI tasks'],
139139
'opcache.jit' => ['recommended' => 'tracing'],
140140
'opcache.jit_buffer_size' => ['recommended' => '128', 'remark' => 'Adjust with your free space of memory'],
141141
'zend.assertions' => ['recommended' => '-1'],
@@ -144,7 +144,7 @@ public static function checkIni(?string $argument = null): array
144144
if ($argument === 'opcache') {
145145
$items = [
146146
'opcache.enable' => ['recommended' => '1'],
147-
'opcache.enable_cli' => ['recommended' => '0', 'remark' => 'Enable when you using CLI'],
147+
'opcache.enable_cli' => ['recommended' => '0', 'remark' => 'Enable when you are using queues or running repetitive CLI tasks'],
148148
'opcache.jit' => ['recommended' => 'tracing', 'remark' => 'Disable when you used third-party extensions'],
149149
'opcache.jit_buffer_size' => ['recommended' => '128', 'remark' => 'Adjust with your free space of memory'],
150150
'opcache.memory_consumption' => ['recommended' => '128', 'remark' => 'Adjust with your free space of memory'],

0 commit comments

Comments
 (0)