Merge pull request #9008 from samsonasik/refactor-closure-void

refactor: enable AddClosureVoidReturnTypeWhereNoReturnRector to add void return on closure

Author: samsonasik

app/Config/Events.php

@@ -23,7 +23,7 @@
  *      Events::on('create', [$myInstance, 'myMethod']);
  */
 
-Events::on('pre_system', static function () {
+Events::on('pre_system', static function (): void {
     if (ENVIRONMENT !== 'testing') {
         if (ini_get('zlib.output_compression')) {
             throw FrameworkException::forEnabledZlibOutputCompression();
@@ -47,7 +47,7 @@
         Services::toolbar()->respond();
         // Hot Reload route - for framework use on the hot reloader.
         if (ENVIRONMENT === 'development') {
-            Services::routes()->get('__hot-reload', static function () {
+            Services::routes()->get('__hot-reload', static function (): void {
                 (new HotReloader())->run();
             });
         }

rector.php

@@ -56,6 +56,7 @@
 use Rector\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector;
 use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\ReturnNeverTypeRector;
+use Rector\TypeDeclaration\Rector\Closure\AddClosureVoidReturnTypeWhereNoReturnRector;
 use Rector\TypeDeclaration\Rector\Empty_\EmptyOnNullableObjectToInstanceOfRector;
 use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
 use Utils\Rector\PassStrictParameterToFunctionParameterRector;
@@ -217,6 +218,7 @@
         SingleInArrayToCompareRector::class,
         VersionCompareFuncCallToConstantRector::class,
         ExplicitBoolCompareRector::class,
+        AddClosureVoidReturnTypeWhereNoReturnRector::class,
     ])
     ->withConfiguredRule(StringClassNameToClassConstantRector::class, [
         // keep '\\' prefix string on string '\Foo\Bar'

system/Autoloader/Autoloader.php

@@ -507,7 +507,7 @@ private function autoloadKint(): void
     {
         // If we have KINT_DIR it means it's already loaded via composer
         if (! defined('KINT_DIR')) {
-            spl_autoload_register(function ($class) {
+            spl_autoload_register(function ($class): void {
                 $class = explode('\\', $class);
 
                 if (array_shift($class) !== 'Kint') {

system/CLI/CLI.php

@@ -857,7 +857,7 @@ public static function wrap(?string $string = null, int $max = 0, int $padLeft =
 
             $first = true;
 
-            array_walk($lines, static function (&$line) use ($padLeft, &$first) {
+            array_walk($lines, static function (&$line) use ($padLeft, &$first): void {
                 if (! $first) {
                     $line = str_repeat(' ', $padLeft) . $line;
                 } else {

system/CodeIgniter.php

@@ -253,7 +253,7 @@ private function autoloadKint(): void
     {
         // If we have KINT_DIR it means it's already loaded via composer
         if (! defined('KINT_DIR')) {
-            spl_autoload_register(function ($class) {
+            spl_autoload_register(function ($class): void {
                 $class = explode('\\', $class);
 
                 if (array_shift($class) !== 'Kint') {

system/DataConverter/DataConverter.php

@@ -140,7 +140,7 @@ public function reconstruct(string $classname, array $row): object
             return $classObj;
         }
 
-        $classSet = Closure::bind(function ($key, $value) {
+        $classSet = Closure::bind(function ($key, $value): void {
             $this->{$key} = $value;
         }, $classObj, $classname);
 

system/Database/Postgre/Builder.php

@@ -159,7 +159,7 @@ public function replace(?array $set = null)
         $table = $this->QBFrom[0];
         $set   = $this->binds;
 
-        array_walk($set, static function (array &$item) {
+        array_walk($set, static function (array &$item): void {
             $item = $item[0];
         });
 

system/Database/Query.php

@@ -118,7 +118,7 @@ public function setQuery(string $sql, $binds = null, bool $setEscape = true)
             }
 
             if ($setEscape) {
-                array_walk($binds, static function (&$item) {
+                array_walk($binds, static function (&$item): void {
                     $item = [
                         $item,
                         true,
@@ -141,7 +141,7 @@ public function setQuery(string $sql, $binds = null, bool $setEscape = true)
     public function setBinds(array $binds, bool $setEscape = true)
     {
         if ($setEscape) {
-            array_walk($binds, static function (&$item) {
+            array_walk($binds, static function (&$item): void {
                 $item = [$item, true];
             });
         }

system/Database/SQLSRV/Builder.php

@@ -420,7 +420,7 @@ protected function _replace(string $table, array $keys, array $values): string
 
         // Get the binds
         $binds = $this->binds;
-        array_walk($binds, static function (&$item) {
+        array_walk($binds, static function (&$item): void {
             $item = $item[0];
         });
 

system/Database/SQLite3/Result.php

@@ -147,7 +147,7 @@ protected function fetchObject(string $className = 'stdClass')
             return $classObj->injectRawData($row);
         }
 
-        $classSet = Closure::bind(function ($key, $value) {
+        $classSet = Closure::bind(function ($key, $value): void {
             $this->{$key} = $value;
         }, $classObj, $className);