chore: Fix phpstan errors

neznaika0 · neznaika0 · commit ff79dcb422cc · 2025-02-23T19:45:58.000+03:00
diff --git a/system/Config/BaseConfig.php b/system/Config/BaseConfig.php
@@ -273,6 +273,7 @@ protected function registerProperties()
         }
 
         $shortName = (new ReflectionClass($this))->getShortName();
+        $worker    = null;
 
         if (isset(static::$moduleConfig->registrarHasData)) {
             // Get all public properties for this config
diff --git a/utils/phpstan-baseline/argument.type.neon b/utils/phpstan-baseline/argument.type.neon
@@ -1,4 +1,4 @@
-# total 73 errors
+# total 147 errors
 
 parameters:
     ignoreErrors:
@@ -122,11 +122,6 @@ parameters:
             count: 1
             path: ../../tests/system/Database/Live/SQLite3/AlterTableTest.php
 
-        -
-            message: '#^Parameter \#2 \$forge of class CodeIgniter\\Database\\SQLite3\\Table constructor expects CodeIgniter\\Database\\SQLite3\\Forge, CodeIgniter\\Database\\Forge given\.$#'
-            count: 1
-            path: ../../tests/system/Database/Live/SQLite3/AlterTableTest.php
-
         -
             message: '#^Parameter \#1 \$set of method CodeIgniter\\Database\\BaseBuilder\:\:updateFields\(\) expects list\<CodeIgniter\\Database\\RawSql\|string\>\|string, array\{0\: ''country'', updated_at\: CodeIgniter\\Database\\RawSql\} given\.$#'
             count: 2
diff --git a/utils/phpstan-baseline/assign.propertyType.neon b/utils/phpstan-baseline/assign.propertyType.neon
@@ -1,4 +1,4 @@
-# total 20 errors
+# total 29 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/codeigniter.cacheHandlerInstance.neon b/utils/phpstan-baseline/codeigniter.cacheHandlerInstance.neon
@@ -1,4 +1,4 @@
-# total 6 errors
+# total 14 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/codeigniter.getReassignArray.neon b/utils/phpstan-baseline/codeigniter.getReassignArray.neon
@@ -1,4 +1,4 @@
-# total 13 errors
+# total 22 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/codeigniter.superglobalAccess.neon b/utils/phpstan-baseline/codeigniter.superglobalAccess.neon
@@ -1,4 +1,4 @@
-# total 53 errors
+# total 83 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/codeigniter.superglobalAccessAssign.neon b/utils/phpstan-baseline/codeigniter.superglobalAccessAssign.neon
@@ -1,4 +1,4 @@
-# total 260 errors
+# total 582 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/codeigniter.unknownServiceMethod.neon b/utils/phpstan-baseline/codeigniter.unknownServiceMethod.neon
@@ -1,4 +1,4 @@
-# total 6 errors
+# total 9 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/empty.notAllowed.neon b/utils/phpstan-baseline/empty.notAllowed.neon
@@ -1,4 +1,4 @@
-# total 77 errors
+# total 271 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/method.alreadyNarrowedType.neon b/utils/phpstan-baseline/method.alreadyNarrowedType.neon
@@ -1,4 +1,4 @@
-# total 16 errors
+# total 22 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/method.childReturnType.neon b/utils/phpstan-baseline/method.childReturnType.neon
@@ -1,4 +1,4 @@
-# total 39 errors
+# total 40 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/method.notFound.neon b/utils/phpstan-baseline/method.notFound.neon
@@ -1,4 +1,4 @@
-# total 40 errors
+# total 83 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/missingType.iterableValue.neon b/utils/phpstan-baseline/missingType.iterableValue.neon
@@ -1,4 +1,4 @@
-# total 1665 errors
+# total 1672 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/missingType.property.neon b/utils/phpstan-baseline/missingType.property.neon
@@ -1,4 +1,4 @@
-# total 127 errors
+# total 130 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/nullCoalesce.property.neon b/utils/phpstan-baseline/nullCoalesce.property.neon
@@ -1,4 +1,4 @@
-# total 15 errors
+# total 22 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/offsetAccess.notFound.neon b/utils/phpstan-baseline/offsetAccess.notFound.neon
@@ -1,4 +1,4 @@
-# total 6 errors
+# total 19 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/property.nonObject.neon b/utils/phpstan-baseline/property.nonObject.neon
@@ -1,4 +1,4 @@
-# total 25 errors
+# total 54 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/property.notFound.neon b/utils/phpstan-baseline/property.notFound.neon
@@ -1,4 +1,4 @@
-# total 30 errors
+# total 58 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/property.protected.neon b/utils/phpstan-baseline/property.protected.neon
@@ -1,4 +1,4 @@
-# total 9 errors
+# total 15 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/property.readOnlyByPhpDocAssignOutOfClass.neon b/utils/phpstan-baseline/property.readOnlyByPhpDocAssignOutOfClass.neon
@@ -1,4 +1,4 @@
-# total 16 errors
+# total 35 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/property.readOnlyByPhpDocDefaultValue.neon b/utils/phpstan-baseline/property.readOnlyByPhpDocDefaultValue.neon
@@ -1,4 +1,4 @@
-# total 7 errors
+# total 21 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/staticMethod.notFound.neon b/utils/phpstan-baseline/staticMethod.notFound.neon
@@ -1,4 +1,4 @@
-# total 7 errors
+# total 20 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/ternary.shortNotAllowed.neon b/utils/phpstan-baseline/ternary.shortNotAllowed.neon
@@ -1,4 +1,4 @@
-# total 27 errors
+# total 38 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/varTag.type.neon b/utils/phpstan-baseline/varTag.type.neon
@@ -1,4 +1,4 @@
-# total 8 errors
+# total 9 errors
 
 parameters:
     ignoreErrors:
diff --git a/utils/phpstan-baseline/variable.undefined.neon b/utils/phpstan-baseline/variable.undefined.neon
@@ -1,4 +1,4 @@
-# total 15 errors
+# total 21 errors
 
 parameters:
     ignoreErrors:

Original file line number	Diff line number	Diff line change
`@@ -273,6 +273,7 @@ protected function registerProperties()`
`273`	`273`	`}`
`274`	`274`
`275`	`275`	`$shortName = (new ReflectionClass($this))->getShortName();`
	`276`	`+ $worker = null;`
`276`	`277`
`277`	`278`	`if (isset(static::$moduleConfig->registrarHasData)) {`
`278`	`279`	`// Get all public properties for this config`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# total 20 errors`
	`1`	`+# total 29 errors`
`2`	`2`
`3`	`3`	`parameters:`
`4`	`4`	`ignoreErrors:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# total 6 errors`
	`1`	`+# total 14 errors`
`2`	`2`
`3`	`3`	`parameters:`
`4`	`4`	`ignoreErrors:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# total 13 errors`
	`1`	`+# total 22 errors`
`2`	`2`
`3`	`3`	`parameters:`
`4`	`4`	`ignoreErrors:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# total 53 errors`
	`1`	`+# total 83 errors`
`2`	`2`
`3`	`3`	`parameters:`
`4`	`4`	`ignoreErrors:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# total 260 errors`
	`1`	`+# total 582 errors`
`2`	`2`
`3`	`3`	`parameters:`
`4`	`4`	`ignoreErrors:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# total 6 errors`
	`1`	`+# total 9 errors`
`2`	`2`
`3`	`3`	`parameters:`
`4`	`4`	`ignoreErrors:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# total 77 errors`
	`1`	`+# total 271 errors`
`2`	`2`
`3`	`3`	`parameters:`
`4`	`4`	`ignoreErrors:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# total 16 errors`
	`1`	`+# total 22 errors`
`2`	`2`
`3`	`3`	`parameters:`
`4`	`4`	`ignoreErrors:`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# total 39 errors`
	`1`	`+# total 40 errors`
`2`	`2`
`3`	`3`	`parameters:`
`4`	`4`	`ignoreErrors:`