Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set headers for CORS #9437

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: set headers for CORS #9437

wants to merge 4 commits into from

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Jan 27, 2025 •
edited
Loading

Description
This PR fixes a bug where CORS was not set correctly due to the response object being returned in the before filter. Now all CORS headers are set in the before filter, and the after filter is no longer used.

This change should not break anyone's code.

Fixes #9431

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 27, 2025
@michalsn michalsn mentioned this pull request Jan 27, 2025
Open
@kenjis
Copy link
Member

kenjis commented Jan 29, 2025

If a dev creates an new Response in a controller, the CORS header will not be added.
E.g, what if using redirect()?

@michalsn
Copy link
Member Author

If a dev creates an new Response in a controller, the CORS header will not be added.
E.g, what if using redirect()?

Fair point.

@codeigniter4 codeigniter4 deleted a comment from mergeable bot Jan 29, 2025
@michalsn
Copy link
Member Author

Second approach. I don't know if we should go into more detail about checking the required headers, but this seems enough.

Basically, we now add CORS headers in the after filter only if they are not already set.

@michalsn michalsn requested a review from samsonasik January 31, 2025 07:41
@neznaika0 neznaika0 mentioned this pull request Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@kenjis kenjis Awaiting requested review from kenjis

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Cors filter can not be used with Shield's Token filter together
3 participants
@michalsn @kenjis @samsonasik