Fix Variable Sequence Length Support for Flash Attention Prefill + KV Cache#359
Merged
aacostadiaz merged 18 commits intointel:sycl-developfrom May 16, 2025
Merged
Conversation
…tlass-fork into varlen_fix_kvcached
muhammad-tanvir-1211
requested review from
FMarno,
aacostadiaz,
joeatodd,
mehdi-goli and
t4c1
mehdi-goli
reviewed
May 9, 2025
applications/flash_attention_v2/collective/xe_flash_attn_epilogue_cachedKV.hpp
Outdated
Show resolved
Hide resolved
mehdi-goli
reviewed
May 9, 2025
applications/flash_attention_v2/collective/xe_flash_attn_mma_cachedKV.hpp
Outdated
Show resolved
Hide resolved
muhammad-tanvir-1211
force-pushed
the
varlen_fix_kvcached
branch
from
a1a74af to
d775639
Compare
mehdi-goli
reviewed
May 9, 2025
applications/flash_attention_v2/collective/xe_flash_attn_epilogue_cachedKV.hpp
Outdated
Show resolved
Hide resolved
mehdi-goli
reviewed
May 9, 2025
applications/flash_attention_v2/collective/xe_flash_attn_mma_cachedKV.hpp
Outdated
Show resolved
Hide resolved
mehdi-goli
approved these changes
May 13, 2025
…tlass-fork into varlen_fix_kvcached
…tlass-fork into varlen_fix_kvcached
…tlass-fork into varlen_fix_kvcached
muhammad-tanvir-1211
force-pushed
the
varlen_fix_kvcached
branch
from
dcfc3e7 to
405348c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes variable sequence length support for Flash Attention Prefill + KV Cache. It also adds unit test for the same.