Skip to content

Commit 76bb8b8

Browse files
committed
fix: test assert raw string paths on different platforms
- use Java's Path to do platform independent path comparison
1 parent 67ec906 commit 76bb8b8

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/test/kotlin/com/coder/toolbox/settings/CoderSettingsTest.kt

+5-5
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import java.nio.file.Path
2525
import kotlin.test.Test
2626
import kotlin.test.assertContains
2727
import kotlin.test.assertEquals
28-
import kotlin.test.assertNotEquals
2928

3029
internal class CoderSettingsTest {
3130
private val logger = mockk<Logger>(relaxed = true)
@@ -114,6 +113,7 @@ internal class CoderSettingsTest {
114113
assertEquals(Path.of(expected).toAbsolutePath(), settings.readOnly().binPath(newUrl).parent)
115114
}
116115

116+
@Test
117117
fun testBinPath() {
118118
val settings = CoderSettingsStore(
119119
pluginTestSettingsStore(
@@ -134,7 +134,7 @@ internal class CoderSettingsTest {
134134
expected = "/tmp/coder-toolbox-test/data-dir/localhost"
135135
assertEquals(Path.of(expected).toAbsolutePath(), settings.readOnly().binPath(url, true).parent)
136136

137-
assertNotEquals("foo-bar.baz", settings.readOnly().binPath(url).fileName.toString())
137+
assertEquals("foo-bar.baz", settings.readOnly().binPath(url).fileName.toString())
138138
}
139139

140140
@Test
@@ -158,7 +158,7 @@ internal class CoderSettingsTest {
158158
OS.MAC -> "/tmp/coder-toolbox-test/cli-home/Library/Application Support/coderv2"
159159
else -> "/tmp/coder-toolbox-test/cli-xdg-config/coderv2"
160160
}
161-
assertEquals(expected, settings.readOnly().globalConfigDir)
161+
assertEquals(Path.of(expected), Path.of(settings.readOnly().globalConfigDir))
162162

163163
// Fall back to HOME on Linux.
164164
if (getOS() == OS.LINUX) {
@@ -174,7 +174,7 @@ internal class CoderSettingsTest {
174174
logger
175175
)
176176
expected = "/tmp/coder-toolbox-test/cli-home/.config/coderv2"
177-
assertEquals(expected, settings.readOnly().globalConfigDir)
177+
assertEquals(Path.of(expected), Path.of(settings.readOnly().globalConfigDir))
178178
}
179179

180180
// Read CODER_CONFIG_DIR.
@@ -193,7 +193,7 @@ internal class CoderSettingsTest {
193193
logger
194194
)
195195
expected = "/tmp/coder-toolbox-test/coder-config-dir"
196-
assertEquals(expected, settings.readOnly().globalConfigDir)
196+
assertEquals(Path.of(expected), Path.of(settings.readOnly().globalConfigDir))
197197
}
198198

199199
@Test

0 commit comments

Comments
 (0)