Skip to content

impl: support for using proxies to access Coder REST API #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2025
Merged

impl: support for using proxies to access Coder REST API #89

merged 4 commits into from
Apr 17, 2025

Conversation

fioan89
Copy link
Collaborator

@fioan89 fioan89 commented Apr 15, 2025

  • proxy credentials are not yet supported as they were not exposed in Toolbox settings
  • system and manual proxy configuration supported.
  • manual tests included system wide settings and manual http settings.
  • resolves Add support for Proxy #39

fioan89 added 2 commits April 15, 2025 23:50
@fioan89
impl: support for using proxies to access Coder REST API
cd068a1 
- proxy credentials are not yet supported as they were not exposed in Toolbox settings
- system and manual proxy configuration supported.
- manual tests included system wide settings and manual http settings.
- resolves #39
@fioan89
chore: next version is 0.2.0
182bc9c
@fioan89 fioan89 requested review from matifali and f0ssel April 15, 2025 21:02
@fioan89
Copy link
Collaborator Author

fioan89 commented Apr 15, 2025 •
edited
Loading

I've created this YT ticket to request the proxy auth. details from Toolbox.
https://youtrack.jetbrains.com/issue/TBX-14532/Missing-proxy-authentication-settings

In the meantime I will try to setup a SOCKS proxy and test it as well.

@matifali matifali removed their request for review April 16, 2025 08:02
@fioan89
Copy link
Collaborator Author

fioan89 commented Apr 16, 2025

SOCKS5 proxy works well as long as authentication is not used.

@fioan89 fioan89 requested a review from f0ssel April 16, 2025 21:55
f0ssel
f0ssel approved these changes Apr 17, 2025
View reviewed changes
Copy link

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I really appreciate the docs on how to replicate the way you are testing, thank!

@fioan89 fioan89 merged commit ec7753b into main Apr 17, 2025
5 checks passed
@fioan89 fioan89 deleted the support-for-proxy-settings branch April 17, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f0ssel f0ssel f0ssel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Proxy
2 participants
@fioan89 @f0ssel