Skip to content

Commit 43abf8e

Browse files
committed
README.md: Revert assembly change for now
1 parent b0ec201 commit 43abf8e

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Diff for: README.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ go get nhooyr.io/websocket
2626
- [RFC 7692](https://tools.ietf.org/html/rfc7692) permessage-deflate compression
2727
- [CloseRead](https://pkg.go.dev/nhooyr.io/websocket#Conn.CloseRead) helper for write only connections
2828
- Compile to [Wasm](https://pkg.go.dev/nhooyr.io/websocket#hdr-Wasm)
29-
- WebSocket masking implemented in assembly for amd64 and arm64 [#326](https://github.com/nhooyr/websocket/issues/326)
3029

3130
## Roadmap
3231

@@ -37,6 +36,8 @@ See GitHub issues for minor issues but the major future enhancements are:
3736
- [ ] Ping pong heartbeat helper [#267](https://github.com/nhooyr/websocket/issues/267)
3837
- [ ] Ping pong instrumentation callbacks [#246](https://github.com/nhooyr/websocket/issues/246)
3938
- [ ] Graceful shutdown helpers [#209](https://github.com/nhooyr/websocket/issues/209)
39+
- [ ] Assembly for WebSocket masking [#16](https://github.com/nhooyr/websocket/issues/16)
40+
- WIP at [#326](https://github.com/nhooyr/websocket/pull/326), about 3x faster
4041
- [ ] HTTP/2 [#4](https://github.com/nhooyr/websocket/issues/4)
4142
- [ ] The holy grail [#402](https://github.com/nhooyr/websocket/issues/402)
4243

@@ -120,8 +121,9 @@ Advantages of nhooyr.io/websocket:
120121
- Gorilla requires registering a pong callback before sending a Ping
121122
- Can target Wasm ([gorilla/websocket#432](https://github.com/gorilla/websocket/issues/432))
122123
- Transparent message buffer reuse with [wsjson](https://pkg.go.dev/nhooyr.io/websocket/wsjson) subpackage
123-
- [3.5x](https://github.com/nhooyr/websocket/pull/326#issuecomment-1959470758) faster WebSocket masking implementation in assembly for amd64 and arm64 and [2x](https://github.com/nhooyr/websocket/releases/tag/v1.7.4) faster implementation in pure Go
124+
- [1.75x](https://github.com/nhooyr/websocket/releases/tag/v1.7.4) faster WebSocket masking implementation in pure Go
124125
- Gorilla's implementation is slower and uses [unsafe](https://golang.org/pkg/unsafe/).
126+
Soon we'll have assembly and be 3x faster [#326](https://github.com/nhooyr/websocket/pull/326)
125127
- Full [permessage-deflate](https://tools.ietf.org/html/rfc7692) compression extension support
126128
- Gorilla only supports no context takeover mode
127129
- [CloseRead](https://pkg.go.dev/nhooyr.io/websocket#Conn.CloseRead) helper for write only connections ([gorilla/websocket#492](https://github.com/gorilla/websocket/issues/492))

0 commit comments

Comments
 (0)