Made is_sparse constexpr and noexcept

herwinw · herwinw · commit 0a953b2190c8 · 2021-02-25T07:54:47.000+01:00
Suggested review comment by @codereport
diff --git a/jsrc/array.hpp b/jsrc/array.hpp
@@ -40,8 +40,8 @@ pointer_to_values(array x) -> int64_t* {
     return reinterpret_cast<int64_t*>(reinterpret_cast<C*>(x) + x->kchain.k);
 }
 
-[[nodiscard]] inline auto
-is_sparse(array x) -> bool {
+[[nodiscard]] constexpr auto
+is_sparse(array x) noexcept -> bool {
     return (AT(x) & SPARSE) != 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,8 @@ pointer_to_values(array x) -> int64_t* {`
`40`	`40`	`return reinterpret_cast<int64_t>(reinterpret_cast<C>(x) + x->kchain.k);`
`41`	`41`	`}`
`42`	`42`
`43`		`-[[nodiscard]] inline auto`
`44`		`-is_sparse(array x) -> bool {`
	`43`	`+[[nodiscard]] constexpr auto`
	`44`	`+is_sparse(array x) noexcept -> bool {`
`45`	`45`	`return (AT(x) & SPARSE) != 0;`
`46`	`46`	`}`
`47`	`47`