New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Memory Reading #177

Open

MrTyton opened this issue Oct 30, 2022 · 0 comments

Assignees

Labels

Contributor

MrTyton commented Oct 30, 2022

Most of the functions within the memory reading should be refactored to use this function

FFX_TAS_Python/memory/main.py

Lines 3344 to 3348 in 2cfcfc8

    
           def readVal(address, bytes=1): 
        
               global baseValue 
        
               key = baseValue + address 
        
               retVal = process.readBytes(key, bytes) 
        
               return retVal

makes the code a lot cleaner and easier to understand.

MrTyton added the refactor label

MrTyton assigned shenef

MrTyton mentioned this issue

Fix 4x speed at wendigo #223

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment