-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate - Summation #188
Comments
I think that kata 1. is good to keep because it has a large coverage of languages and good difficulty. I think kata 3. would be good to keep if it enforced O(1) solutions. The "sum numbers 1 to n" and "triangular numbers" might be not obviously related for total newbies, and I think that spoilers posted into kata 1. are not that relevant on this level. My proposal is to review all languages, make sure that all require O(1) solutions, harden or mark for removal these which do not, and keep the kata. Kata 2. is the worst of the three: it's a blatant duplicate with a lot of annoying things like invalid inputs. Its description might be considered interesting, but even with the description, I think the kata is not worth keeping. |
Languages of kata 3 which allow O(n) solutions:
It will be easy to fix all these languages by increasing the upper bound of tested numbers. |
Obviously, I'm biased since I am the author of Kata 3, but I will throw my vote in for it anyway. When I wrote it (10 years ago), it was not possible to use an O(n) solution in the three original languages, but computers have moved on and an O(n) solution finishes before the timeout. As @monadius says, it would be simple to increase the upper bound to exclude the O(n) solutions. |
Hi, and thanks for sharing your point of view! The question now would be, would you be willing to go through languages of your kata and change tests in a way only O(1) solutions are accepted? Or, if its too much work for you, would you let users provide appropriate forks, and would you approve them? |
I would say to keep 1 + 3. Having only O(1) solutions for the 3rd kata would be also interesting (right now O(n) passes the tests). |
Created a follow-up issue to harden tests of Triangular Treasure: #194 |
From #39
Conclusion
The text was updated successfully, but these errors were encountered: