Removes waitForSubmitted from RequestStorage call.

Author: benbierens

ProjectPlugins/CodexClient/MarketplaceAccess.cs

@@ -46,12 +46,7 @@ public IStoragePurchaseContract RequestStorage(StoragePurchaseRequest purchase)
 
             Log($"Storage requested successfully. PurchaseId: '{response}'.");
 
-            var contract = new StoragePurchaseContract(log, codexAccess, response, purchase, hooks);
-            contract.WaitForStorageContractSubmitted();
-
-            hooks.OnStorageContractSubmitted(contract);
-
-            return contract;
+            return new StoragePurchaseContract(log, codexAccess, response, purchase, hooks);
         }
 
         public string MakeStorageAvailable(StorageAvailability availability)

ProjectPlugins/CodexClient/StoragePurchaseContract.cs

@@ -28,6 +28,7 @@ public class StoragePurchaseContract : IStoragePurchaseContract
         private DateTime? contractSubmittedUtc = DateTime.UtcNow;
         private DateTime? contractStartedUtc;
         private DateTime? contractFinishedUtc;
+        private string lastState = string.Empty;
 
         public StoragePurchaseContract(ILog log, CodexAccess codexAccess, string purchaseId, StoragePurchaseRequest purchase, ICodexNodeHooks hooks)
         {
@@ -54,8 +55,10 @@ public StoragePurchase GetStatus()
 
         public void WaitForStorageContractSubmitted()
         {
+            var raiseHook = lastState != "submitted";
             WaitForStorageContractState(gracePeriod, "submitted", sleep: 200);
             contractSubmittedUtc = DateTime.UtcNow;
+            if (raiseHook) hooks.OnStorageContractSubmitted(this);
             LogSubmittedDuration();
             AssertDuration(PendingToSubmitted, gracePeriod, nameof(PendingToSubmitted));
         }
@@ -102,7 +105,6 @@ public StoragePurchase GetPurchaseStatus()
 
         private void WaitForStorageContractState(TimeSpan timeout, string desiredState, int sleep = 1000)
         {
-            var lastState = "";
             var waitStart = DateTime.UtcNow;
 
             Log($"Waiting for {Time.FormatDuration(timeout)} to reach state '{desiredState}'.");

Tools/AutoClient/Modes/FolderStore/FileSaver.cs

@@ -158,6 +158,9 @@ private void CreateNewPurchase()
                 WaitForSubmitted(request);
                 WaitForStarted(request);
 
+                stats.StorageRequestStats.SuccessfullyStarted++;
+                saveChanges();
+
                 Log($"Successfully started new purchase: '{entry.PurchaseId}' for {Time.FormatDuration(request.Purchase.Duration)}");
             }
             catch (Exception exc)
@@ -178,7 +181,6 @@ private IStoragePurchaseContract CreateNewStorageRequest()
                 entry.EncodedCid = request.Purchase.ContentId.Id;
                 entry.PurchaseId = request.PurchaseId;
                 entry.PurchaseFinishedUtc = DateTime.UtcNow + request.Purchase.Duration;
-                stats.StorageRequestStats.SuccessfullyStarted++;
                 saveChanges();
                 Log("Saved new purchaseId: " + entry.PurchaseId);
                 return request;