Skip to content

Commit 6523e70

Browse files
authored
fix: items(JsonNode) symbol not found (#87)
* chore: export subscriptions This has a knock-on effect of nim-serde not being imported into subscriptions when JsonRpcProvider.new is called from a consumer that does not export nim-serde. * import/export serde * Replace all instances of std/json with pkg/serde
1 parent 765379a commit 6523e70

File tree

10 files changed

+12
-8
lines changed

10 files changed

+12
-8
lines changed

ethers/contract.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import std/json
1+
import pkg/serde
22
import std/macros
33
import std/sequtils
44
import pkg/chronicles

ethers/nimshims/hashes.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
## `std/json.JsonNode.hash`, eg when using `JsonNode` as a `Table` key. Adds
33
## {.raises: [].} for proper exception tracking. Copied from the std/json module
44

5-
import std/json
5+
import pkg/serde
66
import std/hashes
77

88
{.push raises:[].}

ethers/providers/jsonrpc.nim

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ export basics
1717
export provider
1818
export chronicles
1919
export errors.JsonRpcProviderError
20+
export subscriptions
2021

2122
{.push raises: [].}
2223

ethers/providers/jsonrpc/subscriptions.nim

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,16 @@ import std/sequtils
33
import std/strutils
44
import pkg/chronos
55
import pkg/json_rpc/rpcclient
6+
import pkg/serde
67
import ../../basics
78
import ../../provider
89
include ../../nimshims/hashes
910
import ./rpccalls
1011
import ./conversions
1112
import ./looping
1213

14+
export serde
15+
1316
type
1417
JsonRpcSubscriptions* = ref object of RootObj
1518
client: RpcClient

testmodule/hardhat.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import std/json
1+
import pkg/serde
22
import pkg/ethers/basics
33

44
type Deployment* = object

testmodule/providers/jsonrpc/testErrors.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import std/unittest
2-
import std/json
2+
import pkg/serde
33
import pkg/questionable
44
import pkg/ethers/providers/jsonrpc/errors
55

testmodule/providers/jsonrpc/testJsonRpcSubscriptions.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import std/json
1+
import pkg/serde
22
import std/os
33
import std/sequtils
44
import std/importutils

testmodule/testContracts.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import std/json
1+
import pkg/serde
22
import std/os
33
import std/options
44
import pkg/asynctest

testmodule/testCustomErrors.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import std/os
2-
import std/json
2+
import pkg/serde
33
import pkg/asynctest
44
import pkg/ethers
55
import ./hardhat

testmodule/testErc20.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import std/os
2-
import std/json
2+
import pkg/serde
33
import pkg/asynctest
44
import pkg/questionable
55
import pkg/stint

0 commit comments

Comments
 (0)