Skip to content

Commit 8eeb0c8

Browse files
committed
Delete whole transaction when transaction is deleted, not just the split of the relevant account.
Update version code and changelog
1 parent e4e1fb3 commit 8eeb0c8

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ Version 1.5.2 *(2015-01-26)*
66
* Fixed: Full name not updated when account name is changed
77
* Fixed: Toggle button shown when double-entry is disabled
88
* Fixed: Amount input problems on some devices or keyboards
9+
* Fixed: Crash when changing the parent of an account
10+
* Fixed: Deleting a transaction only deletes some splits, not the whole.
911

1012
Version 1.5.1 *(2014-10-08)*
1113
----------------------------

app/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
1919
package="org.gnucash.android"
20-
android:versionCode="44"
20+
android:versionCode="45"
2121
android:versionName="@string/app_version_name" >
2222

2323
<uses-sdk android:minSdkVersion="8" android:targetSdkVersion="16"/>

app/src/org/gnucash/android/ui/transaction/TransactionsListFragment.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,9 @@ public boolean onActionItemClicked(ActionMode mode, MenuItem item) {
117117
return true;
118118

119119
case R.id.context_menu_delete:
120-
SplitsDbAdapter splitsDbAdapter = new SplitsDbAdapter(getActivity());
121120
for (long id : getListView().getCheckedItemIds()) {
122-
splitsDbAdapter.deleteSplitsForTransactionAndAccount(mTransactionsDbAdapter.getUID(id), mAccountUID);
121+
mTransactionsDbAdapter.deleteRecord(id);
123122
}
124-
splitsDbAdapter.close();
125123
refresh();
126124
mode.finish();
127125
WidgetConfigurationActivity.updateAllWidgets(getActivity());

0 commit comments

Comments
 (0)