Fix incorrect balance calculation for OFX

codinguser · codinguser · commit 9374d08f5df2 · 2018-01-01T17:08:48.000+01:00
diff --git a/app/src/main/java/org/gnucash/android/model/Account.java b/app/src/main/java/org/gnucash/android/model/Account.java
@@ -269,7 +269,7 @@ public int getTransactionCount() {
     public Money getBalance() {
         Money balance = Money.createZeroInstance(mCommodity.getCurrencyCode());
         for (Transaction transaction : mTransactionsList) {
-            balance.add(transaction.getBalance(getUID()));
+            balance = balance.add(transaction.getBalance(getUID()));
         }
         return balance;
     }

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ public int getTransactionCount() {`
`269`	`269`	`public Money getBalance() {`
`270`	`270`	`Money balance = Money.createZeroInstance(mCommodity.getCurrencyCode());`
`271`	`271`	`for (Transaction transaction : mTransactionsList) {`
`272`		`- balance.add(transaction.getBalance(getUID()));`
	`272`	`+ balance = balance.add(transaction.getBalance(getUID()));`
`273`	`273`	`}`
`274`	`274`	`return balance;`
`275`	`275`	`}`