Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use dewpoint function in wetbulb #1

Closed
ccarouge opened this issue Aug 10, 2021 · 4 comments · May be fixed by #14
Closed

use dewpoint function in wetbulb #1

ccarouge opened this issue Aug 10, 2021 · 4 comments · May be fixed by #14

Comments

@ccarouge
Copy link
Member

The start of wetbulb function is the same as the dewpoint function. Use the function instead of replicating the code.
@HoWol76
Copy link

HoWol76 commented Sep 9, 2021

I made a few refactoring changes in the branch refactor, including this.

@HoWol76 HoWol76 mentioned this issue Sep 9, 2021
Open
@aidanheerdegen
Copy link
Member

At the risk of being a wet bulb, this duplicates functionality that is available in metpy

https://unidata.github.io/MetPy/latest/api/generated/metpy.calc.wet_bulb_temperature.html

https://unidata.github.io/MetPy/latest/api/generated/metpy.calc.dewpoint.html

https://unidata.github.io/MetPy/latest/api/generated/metpy.calc.relative_humidity_from_specific_humidity.html

It would be better to use well tested functions from metpy IMO

@aidanheerdegen
Copy link
Member

Also metpy already uses pint see #2

@aidanheerdegen aidanheerdegen mentioned this issue Apr 12, 2022
Closed
@greensh16
Copy link
Contributor

The code is now using the wet_bulb_temperture, dewpoint, and relative_humidity_from_specific_humidity functions from metpy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor coecms/frontdetection
4 participants
@HoWol76 @aidanheerdegen @ccarouge @greensh16