Skip to content

Commit ae8e383

Browse files
author
Kubernetes Submit Queue
authored
Merge pull request kubernetes#49960 from zmerlynn/automated-cherry-pick-of-#49043-upstream-release-1.7
Automatic merge from submit-queue Automated cherry pick of kubernetes#49043 Cherry pick of kubernetes#49043 on release-1.7. kubernetes#49043: cluster/gke: If NODE_INSTANCE_GROUP is set, don't execute any Fixes kubernetes#49939
2 parents f780eb1 + 70bdf85 commit ae8e383

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

hack/ginkgo-e2e.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@ fi
7676

7777
if [[ -n "${NODE_INSTANCE_PREFIX:-}" ]]; then
7878
NODE_INSTANCE_GROUP="${NODE_INSTANCE_PREFIX}-group"
79-
else
80-
NODE_INSTANCE_GROUP=""
8179
fi
8280

8381
if [[ "${KUBERNETES_PROVIDER}" == "gce" ]]; then
@@ -93,7 +91,10 @@ if [[ "${KUBERNETES_PROVIDER}" == "gce" ]]; then
9391
done
9492
fi
9593

96-
if [[ "${KUBERNETES_PROVIDER}" == "gke" ]]; then
94+
# TODO(kubernetes/test-infra#3330): Allow NODE_INSTANCE_GROUP to be
95+
# set before we get here, which eliminates any cluster/gke use if
96+
# KUBERNETES_CONFORMANCE_PROVIDER is set to "gke".
97+
if [[ -z "${NODE_INSTANCE_GROUP:-}" ]] && [[ "${KUBERNETES_PROVIDER}" == "gke" ]]; then
9798
detect-node-instance-groups
9899
NODE_INSTANCE_GROUP=$(kube::util::join , "${NODE_INSTANCE_GROUPS[@]}")
99100
fi

0 commit comments

Comments
 (0)