Skip to content

Commit 2afe5f1

Browse files
nursixflavour
authored andcommitted
Default for person first names, revert fix
1 parent e71bf98 commit 2afe5f1

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

modules/eden/pr.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,9 @@ def model(self):
544544
readable=False,
545545
writable=False,
546546
default=False),
547-
Field("first_name", notnull=True,
547+
Field("first_name",
548+
notnull=True,
549+
default="?",
548550
length=64, # Mayon Compatibility
549551
# NB Not possible to have an IS_NAME() validator here
550552
# http://eden.sahanafoundation.org/ticket/834

modules/s3/s3import.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2726,14 +2726,14 @@ def add_item(self,
27262726
components = model.get_components(table, names=components)
27272727
for alias in components:
27282728
component = components[alias]
2729-
if component.link:
2730-
target = component.link
2731-
else:
2732-
target = component
2733-
ctable = component.table
2734-
ctablename = component.tablename
27352729
pkey = component.pkey
2736-
fkey = component.fkey
2730+
if component.linktable:
2731+
ctable = component.linktable
2732+
fkey = component.lkey
2733+
else:
2734+
ctable = component.table
2735+
fkey = component.fkey
2736+
ctablename = ctable._tablename
27372737

27382738
celements = xml.select_resources(element, ctablename)
27392739
if celements:
@@ -2905,7 +2905,7 @@ def lookahead(self,
29052905
if directory is not None:
29062906
entry = directory.get((tablename, attr, uid), None)
29072907
if not entry:
2908-
expr = './/%s[@%s="%s" and @%s="%s"]' % (
2908+
expr = ".//%s[@%s='%s' and @%s='%s']" % (
29092909
xml.TAG.resource,
29102910
xml.ATTRIBUTE.name,
29112911
tablename,

0 commit comments

Comments
 (0)