From 6f498299d8319e28f00dd8e9299a397a13aebde4 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Wed, 1 Jan 2025 12:05:22 +0800 Subject: [PATCH 1/8] . --- main/eval/test/src/mill/eval/EvaluationTests.scala | 1 + 1 file changed, 1 insertion(+) diff --git a/main/eval/test/src/mill/eval/EvaluationTests.scala b/main/eval/test/src/mill/eval/EvaluationTests.scala index 7defb75553ae..5a3a77e188ee 100644 --- a/main/eval/test/src/mill/eval/EvaluationTests.scala +++ b/main/eval/test/src/mill/eval/EvaluationTests.scala @@ -228,6 +228,7 @@ class EvaluationTests(threadCount: Option[Int]) extends TestSuite { val overridden = os.read( checker.evaluator.outPath / "foo.super/BaseModule.json" ) + throw new Exception("boom") assert( public.contains("base"), public.contains("object"), From f9b9a7c7afee20e159f0e712a2b5e224fd8e0975 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Wed, 1 Jan 2025 12:17:51 +0800 Subject: [PATCH 2/8] . --- .github/workflows/post-build-selective.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/post-build-selective.yml b/.github/workflows/post-build-selective.yml index 095c471763c2..5ccc7580cd22 100644 --- a/.github/workflows/post-build-selective.yml +++ b/.github/workflows/post-build-selective.yml @@ -80,6 +80,5 @@ jobs: fail_on_failure: false include_passed: false detailed_summary: true - annotate_only: true require_tests: false report_paths: 'out/**/test-report.xml' From 6bde3fcb022a25f5576ce5459865c96eb792344f Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Wed, 1 Jan 2025 12:27:35 +0800 Subject: [PATCH 3/8] . --- .github/workflows/run-tests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index e52818a50610..9c054b2fff34 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -1,5 +1,8 @@ name: Run Tests +permissions: + checks: write + # We run full CI on push builds to main and on all pull requests # # Manual builds (workflow_dispatch) to the main branch are also published From 6f55c9ca5334574073d8a2e37c918b9e08757890 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Wed, 1 Jan 2025 12:45:36 +0800 Subject: [PATCH 4/8] . --- .github/workflows/post-build-selective.yml | 4 +--- .github/workflows/run-tests.yml | 3 --- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/post-build-selective.yml b/.github/workflows/post-build-selective.yml index 5ccc7580cd22..b8db12b6d131 100644 --- a/.github/workflows/post-build-selective.yml +++ b/.github/workflows/post-build-selective.yml @@ -77,8 +77,6 @@ jobs: uses: mikepenz/action-junit-report@v5 if: always() # always run even if the previous step fails with: - fail_on_failure: false - include_passed: false + summary: true detailed_summary: true - require_tests: false report_paths: 'out/**/test-report.xml' diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 9c054b2fff34..e52818a50610 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -1,8 +1,5 @@ name: Run Tests -permissions: - checks: write - # We run full CI on push builds to main and on all pull requests # # Manual builds (workflow_dispatch) to the main branch are also published From 1e4cc1210ca75658c31aeb22bdf54e46ba6655b6 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Wed, 1 Jan 2025 13:12:51 +0800 Subject: [PATCH 5/8] permissions --- .github/workflows/run-tests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index e52818a50610..9c054b2fff34 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -1,5 +1,8 @@ name: Run Tests +permissions: + checks: write + # We run full CI on push builds to main and on all pull requests # # Manual builds (workflow_dispatch) to the main branch are also published From ea9cb82a56630944bbb9c963f33b3ccbc879c3b0 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Wed, 1 Jan 2025 13:27:33 +0800 Subject: [PATCH 6/8] permissions --- .github/workflows/post-build-selective.yml | 1 - .github/workflows/run-tests.yml | 3 --- 2 files changed, 4 deletions(-) diff --git a/.github/workflows/post-build-selective.yml b/.github/workflows/post-build-selective.yml index b8db12b6d131..b8d064403ef4 100644 --- a/.github/workflows/post-build-selective.yml +++ b/.github/workflows/post-build-selective.yml @@ -77,6 +77,5 @@ jobs: uses: mikepenz/action-junit-report@v5 if: always() # always run even if the previous step fails with: - summary: true detailed_summary: true report_paths: 'out/**/test-report.xml' diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 9c054b2fff34..e52818a50610 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -1,8 +1,5 @@ name: Run Tests -permissions: - checks: write - # We run full CI on push builds to main and on all pull requests # # Manual builds (workflow_dispatch) to the main branch are also published From a798f043c4c54af24941f18c85550cb49cdd2267 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Wed, 1 Jan 2025 13:27:54 +0800 Subject: [PATCH 7/8] permissions --- .github/workflows/post-build-selective.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/post-build-selective.yml b/.github/workflows/post-build-selective.yml index b8d064403ef4..e78708601945 100644 --- a/.github/workflows/post-build-selective.yml +++ b/.github/workflows/post-build-selective.yml @@ -77,5 +77,7 @@ jobs: uses: mikepenz/action-junit-report@v5 if: always() # always run even if the previous step fails with: + summary: true detailed_summary: true + annotate_only: true report_paths: 'out/**/test-report.xml' From ef321abd7dec5e35c30e55180034b0d3e4e60dfb Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Wed, 1 Jan 2025 13:50:57 +0800 Subject: [PATCH 8/8] Update post-build-selective.yml --- .github/workflows/post-build-selective.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/post-build-selective.yml b/.github/workflows/post-build-selective.yml index e78708601945..603a1734cee9 100644 --- a/.github/workflows/post-build-selective.yml +++ b/.github/workflows/post-build-selective.yml @@ -80,4 +80,5 @@ jobs: summary: true detailed_summary: true annotate_only: true + truncate_stack_traces: false report_paths: 'out/**/test-report.xml'