Replies: 1 comment
-
I think you may want to open an issue in the https://github.com/Comfy-Org/rfcs repo to get more feedback on this. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Would you be open to accepting a pull request that replaces
aiohttp
with FastAPI?We recently completed implementing our HTTP/1.1 API in Visionatrix to handle tasks for ComfyUI, but we still need to retain the original ComfyUI frontend interface.
Since we're using FastAPI, it's not straightforward to integrate ComfyUI's endpoints into our project without reimplementing them from scratch.
While I'm confident I could reimplement the endpoints myself, and they would likely maintain full backward compatibility with the original
aiohttp
endpoints, it would be far more convenient to avoid doing this in our own repository. Constantly syncing backend changes from ComfyUI would be cumbersome. Instead, it would be ideal to submit a PR to this repository, replacingaiohttp
with FastAPI.With that change, we could simply import the routes into our project, making everything seamless and easy to manage.
So, my question for you, @comfyanonymous, @mcmonkey4eva, is: would you consider accepting a PR that replaces
aiohttp
with FastAPI if it will retain backward compatibility with current endpoints?Thank you in advance for your consideration, no matter the response!
Beta Was this translation helpful? Give feedback.
All reactions