Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upscale Image (Using Model) using CPU only? #6777

Open
Oruli opened this issue Feb 11, 2025 · 2 comments
Open

Upscale Image (Using Model) using CPU only? #6777

Oruli opened this issue Feb 11, 2025 · 2 comments
Labels
User Support A user needs help with something, probably not a bug.

Comments

@Oruli
Copy link

Oruli commented Feb 11, 2025

Your question

Is this expected behaviour? I can't find any information anywhere but when I run this model on a large video specifically it takes a very very long time and runs CPU at 100% across all cores

Logs

Other

No response

@Oruli Oruli added the User Support A user needs help with something, probably not a bug. label Feb 11, 2025
@LukeG89
Copy link

LukeG89 commented Feb 11, 2025

ComfyUI is probably offloading on RAM since it's a video, if you are giving a large batch of images to Upscale Image (Using Model), it will process all the batch at the same time and that can be overwhelming for the system.
For example, if it's a 80 frames video, you are giving a batch of 80 images to the upscaler.

A good trick when upscaling videos is to convert the batch to a list and, after the process, convert the list to a batch.
This way, it will upscale a frame at a time.

upscale_list

@Oruli
Copy link
Author

Oruli commented Feb 11, 2025

ComfyUI is probably offloading on RAM since it's a video, if you are giving a large batch of images to Upscale Image (Using Model), it will process all the batch at the same time and that can be overwhelming for the system. For example, if it's a 80 frames video, you are giving a batch of 80 images to the upscaler.

A good trick when upscaling videos is to convert the batch to a list and, after the process, convert the list to a batch. This way, it will upscale a frame at a time.

upscale_list

Well most videos are 24fps and 5+ seconds on Hunyuan, so that's a lot of images and it seems this method is even slower than before.

I'm just wondering why with 24GB of compute the GPU is only at 2GB and CPU 100%, surely it should be using the GPU to upscale?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Support A user needs help with something, probably not a bug.
Projects
None yet
Development

No branches or pull requests

2 participants