Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show a thumbnail when sharing link #547

Open
BBBmau opened this issue Jul 29, 2024 · 1 comment
Open

show a thumbnail when sharing link #547

BBBmau opened this issue Jul 29, 2024 · 1 comment

Comments

@BBBmau
Copy link
Contributor

BBBmau commented Jul 29, 2024

Would be nice for the link to show a picture that comes from the segment being shared instead of just the comma logoScreenshot_20240729-113512.png

@Raamzeez
Copy link

@BBBmau I've been working on this for a bit and I have gotten it to a point where I can get the base64 image data from a frame in the segment, and added the appropriate meta tag with the "og:image" property.

<meta property="og:image" content={frameUrl} />

However, in order for the image to show when sharing the url, the content property needs to be given an absolute url pointing to the image, so we will need to have the image hosted somewhere. Do we already have an image hosting source, or is that in the works? Also I just realized that there is a rewrite of the comma connect web app, but I can easily import the code over once the image hosting is figured out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants