Option group - empty name tests + ignore required tests

Author: hadzhiyski

tests/CommandLine.Tests/Fakes/Simple_Options_With_OptionGroup_WithDefaultValue.cs

@@ -0,0 +1,14 @@
+namespace CommandLine.Tests.Fakes
+{
+    public class Simple_Options_With_OptionGroup_WithDefaultValue
+    {
+        [Option(HelpText = "Define a string value here.", Required = true, Group = "")]
+        public string StringValue { get; set; }
+
+        [Option('s', "shortandlong", HelpText = "Example with both short and long name.", Required = true, Group = "")]
+        public string ShortAndLong { get; set; }
+
+        [Option('x', HelpText = "Define a boolean or switch value here.")]
+        public bool BoolValue { get; set; }
+    }
+}

tests/CommandLine.Tests/Fakes/Simple_Options_With_Required_OptionGroup.cs

@@ -5,7 +5,7 @@ public class Simple_Options_With_Required_OptionGroup
         [Option(HelpText = "Define a string value here.", Required = true, Group = "string-group")]
         public string StringValue { get; set; }
 
-        [Option('s', "shortandlong", HelpText = "Example with both short and long name.", Group = "string-group")]
+        [Option('s', "shortandlong", HelpText = "Example with both short and long name.", Required = true, Group = "string-group")]
         public string ShortAndLong { get; set; }
 
         [Option('x', HelpText = "Define a boolean or switch value here.")]

tests/CommandLine.Tests/Unit/Core/InstanceBuilderTests.cs

@@ -1,16 +1,19 @@
-// Copyright 2005-2015 Giacomo Stelluti Scala & Contributors. All rights reserved. See License.md in the project root for license information.
+// Copyright 2005-2015 Giacomo Stelluti Scala & Contributors. All rights reserved. See License.md in the project root for license information.
 
-using System;
-using System.Collections.Generic;
-using System.Globalization;
-using System.Linq;
 using Microsoft.FSharp.Core;
 using CommandLine.Core;
 using CommandLine.Infrastructure;
+using CommandLine.Tests.Fakes;
 
 using CSharpx;
-using CommandLine.Tests.Fakes;
+
 using FluentAssertions;
+
+using System;
+using System.Collections.Generic;
+using System.Globalization;
+using System.Linq;
+
 using Xunit;
 using System.Reflection;
 
@@ -1194,6 +1197,47 @@ public void Options_In_Group_With_Values_Does_Not_Generate_MissingGroupOptionErr
             // Teardown
         }
 
+        [Fact]
+        public void Options_In_Group_WithRequired_Does_Not_Generate_RequiredError()
+        {
+            // Fixture setup
+            var optionNames = new List<NameInfo>
+            {
+                new NameInfo("", "stingvalue"),
+                new NameInfo("s", "shortandlong")
+            };
+            var expectedResult = new[] { new MissingGroupOptionError("string-group", optionNames) };
+
+            // Exercize system 
+            var result = InvokeBuild<Simple_Options_With_Required_OptionGroup>(new string[] { "-x" });
+
+            // Verify outcome
+            result.Should().BeOfType<NotParsed<Simple_Options_With_Required_OptionGroup>>();
+            var errors = ((NotParsed<Simple_Options_With_Required_OptionGroup>)result).Errors;
+
+            errors.Should().HaveCount(1);
+            errors.Should().BeEquivalentTo(expectedResult);
+        }
+
+        [Fact]
+        public void Options_In_Group_Ignore_Option_Group_If_Option_Group_Name_Empty()
+        {
+            var expectedResult = new[]
+            {
+                new MissingRequiredOptionError(new NameInfo("", "stringvalue")),
+                new MissingRequiredOptionError(new NameInfo("s", "shortandlong"))
+            };
+
+            // Exercize system 
+            var result = InvokeBuild<Simple_Options_With_OptionGroup_WithDefaultValue>(new string[] { "-x" });
+
+            // Verify outcome
+            result.Should().BeOfType<NotParsed<Simple_Options_With_OptionGroup_WithDefaultValue>>();
+            var errors = ((NotParsed<Simple_Options_With_OptionGroup_WithDefaultValue>)result).Errors;
+
+            errors.Should().BeEquivalentTo(expectedResult);
+        }
+
         private class ValueWithNoSetterOptions
         {
             [Value(0, MetaName = "Test", Default = 0)]