Remove duplication by delegating calls to CreateDefaultImmutableInstance<T>(Type[]) to the overloaded function CreateDefaultImmutableInstance(Type, Type[]) which has the same code and logic.

johndkane · johndkane · commit 2da82095b5a7 · 2018-12-01T16:52:53.000-05:00
diff --git a/src/CommandLine/Infrastructure/ReflectionHelper.cs b/src/CommandLine/Infrastructure/ReflectionHelper.cs
@@ -84,11 +84,8 @@ public static bool IsFSharpOptionType(Type type)
 
         public static T CreateDefaultImmutableInstance<T>(Type[] constructorTypes)
         {
-            var t = typeof(T);
-            var ctor = t.GetTypeInfo().GetConstructor(constructorTypes);
-            var values = (from prms in ctor.GetParameters()
-                          select prms.ParameterType.CreateDefaultForImmutable()).ToArray();
-            return (T)ctor.Invoke(values);
+            var t = typeof(T);            
+            return (T)CreateDefaultImmutableInstance(t, constructorTypes);
         }
 
         public static object CreateDefaultImmutableInstance(Type type, Type[] constructorTypes)

Original file line number	Diff line number	Diff line change
`@@ -84,11 +84,8 @@ public static bool IsFSharpOptionType(Type type)`
`84`	`84`
`85`	`85`	`public static T CreateDefaultImmutableInstance<T>(Type[] constructorTypes)`
`86`	`86`	`{`
`87`		`- var t = typeof(T);`
`88`		`- var ctor = t.GetTypeInfo().GetConstructor(constructorTypes);`
`89`		`- var values = (from prms in ctor.GetParameters()`
`90`		`- select prms.ParameterType.CreateDefaultForImmutable()).ToArray();`
`91`		`- return (T)ctor.Invoke(values);`
	`87`	`+ var t = typeof(T);`
	`88`	`+ return (T)CreateDefaultImmutableInstance(t, constructorTypes);`
`92`	`89`	`}`
`93`	`90`
`94`	`91`	`public static object CreateDefaultImmutableInstance(Type type, Type[] constructorTypes)`