-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commandline/src/CommandLine/Text/HelpText.cs AddLine() calls value.Trim() stripping out example spacing #236
Comments
Perhaps replace with: |
… and help text formatting (commandlineparser#236) bugs. ----- 1. Added ignoreValueCase param to methods in InstanceChooser.cs. Passed this arg through call stack. 2. Modified Parser.cs to use settings.CaseInsensitiveEnumValues. 3. Added NewLine before UsageHeadingText in HelpText.cs. 4. Commented-out Trim method call in HelpText.cs.
@nemec et al, it seems like we should come up with a formal specification about how the help text renders by default. Otherwise I think other's preferences will start leaking into tests and additional PRs like #280. I personally don't mind the changes that #280 makes but I can see it going back and forth, tabs/spaces etc. (ugh, worried about the upcoming flame war just mentioning that) |
I'm okay with #280 as well, considering that indent is hardcoded and was accidentally getting thrown away. I also agree that |
In generating help text spacing is supposed to be prefixed to the start of the line to make Usage sections easier to read.
AddLine() calls .Trim() which removes spacing from the start of the line. Since whitespace is used for formatting it should not be calling Trim()
The text was updated successfully, but these errors were encountered: