Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Handling of Nonexistent or Mis-cased Paths #8

Open
thunderpoot opened this issue Feb 14, 2025 · 0 comments
Open

Incorrect Handling of Nonexistent or Mis-cased Paths #8

thunderpoot opened this issue Feb 14, 2025 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@thunderpoot
Copy link
Member

Describe the bug
When downloading paths with a segment that doesn't exist (or one that does but is not written in the correct case such as cc-main-2025-05 in lowercase) it will save the file with the expected name and .gz extension but it will contain the S3 error:

$ cat warc.paths.gz
<?xml version="1.0" encoding="UTF-8"?>
<Error><Code>NoSuchKey</Code><Message>The specified key does not exist.</Message><Key>crawl-data/asdfadsf/warc.paths.gz</Key><RequestId>NYVQWQNC27BD94GE</RequestId><HostId>RoAV4secLh5r9pf8ixAFKbMObnFnJ0tGI0m80X9NzxInsR7RILRIoT/cKekF/y7VlctccRX3CPQ=</HostId></Error>%                                                                                  

To Reproduce
Steps to reproduce the behavior:

cc-downloader download-paths asdfadsf warc .

Expected behavior
I would have expected it to tell me that the path was not found. The tool could check the existence of the path before attempting to download and fail gracefully with a nice user-friendly message instead of saving an error response.

@thunderpoot thunderpoot added bug Something isn't working enhancement New feature or request labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant