Skip to content

Commit fa7c647

Browse files
Francois Budinjcfr
Francois Budin
authored andcommitted
Remove INSTALL_NAME_DIR target property
Using INSTALL_NAME_DIR target property forces the install name to be an absolute path instead of `@rpath/{target_name}` [1]. This causes problems when one tries to relocate the target once it is installed. This patch removes this target property. If a project needs to keep the absolute path, CMake variables such as INSTALL_NAME_DIR can be set at configuration to do so. [1] https://gitlab.kitware.com/cmake/cmake/issues/16589
1 parent 8462a54 commit fa7c647

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

CMakeLists.txt

-8
Original file line numberDiff line numberDiff line change
@@ -309,14 +309,6 @@ add_library(PythonQt SHARED
309309
)
310310
set_target_properties(PythonQt PROPERTIES DEFINE_SYMBOL PYTHONQT_EXPORTS)
311311

312-
#
313-
# That should solve linkage error on Mac when the project is used in a superbuild setup
314-
# See http://blog.onesadcookie.com/2008/01/installname-magic.html
315-
#
316-
set_target_properties(PythonQt PROPERTIES
317-
INSTALL_NAME_DIR "${CMAKE_INSTALL_PREFIX}/lib"
318-
)
319-
320312
target_compile_options(PythonQt PRIVATE
321313
$<$<CXX_COMPILER_ID:MSVC>:/bigobj>
322314
)

0 commit comments

Comments
 (0)