Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charges tab not visible with JS disabled due to unclosed div #221

Open
hlandau opened this issue May 15, 2021 · 0 comments
Open

Charges tab not visible with JS disabled due to unclosed div #221

hlandau opened this issue May 15, 2021 · 0 comments

Comments

@hlandau
Copy link

hlandau commented May 15, 2021

When JS is disabled nothing is shown under the "charges" tab. This appears to be due to an unclosed js-only div shown here:

<div class="js-only">
<form id="mortgage-filter" class="form grid-row">
<div class="column-half">
<h2 class="heading-medium"><% l('Filter charges') %></h2>
<fieldset>
<legend class="visuallyhidden">Filter charges</legend>
% for $filters -> $filter {
<label id="filter-<% $filter.id %>_label" for="filter-<% $filter.id %>" class="block-label selection-button-checkbox">
<input id="filter-<% $filter.id %>" name="filter" value="<% $filter.id %>" type="checkbox" <% $filter.checked ? 'checked' : '' %> />
<% l($filter.name) %>
</label>
% if $~filter.count == $split_filter_at {
</div>
<div class="column-quarter">
% }
% }
</fieldset>
<input id="submit-filter" class="button js-hidden" type="submit" value="<% l('Apply filter') %>">
</form>
</div>

The indentation suggests this tag is closed, but the HTML inside it is not closed correctly, thus all remaining content falls under js-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant