Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit button for seed comments is not disabled when conversation is closed #1897

Open
jedesroches opened this issue Feb 5, 2025 · 1 comment

Comments

@jedesroches
Copy link

Expected behavior: When the conversation is closed, the "Submit" button under the text field for seed comments should be greyed out (or even the whole component disabled ?), whith some text explaining that comments can only be added in an open conversation.

Actual behavior: Currently, it is possible to write a seed comment and try to submit it, only to get an unformatted error that the conversation is closed, which is confusing for non-technical users.

To Reproduce: Create a new conversation, untick the "Conversation is open" box and try to add a seed comment.

Additional context: This is mostly a UX problem more than a bug, but it did confuse quite a few of my users initially :)

@endic-sam928281
Copy link

Hello, we tried to solve the issue.

This is what we did:

Modified the ConversationConfig component to pass the is_active prop to the ModerateCommentsSeed component. This will allow the seed comment component to know whether the conversation is open or closed.

You can review changes in this commit: endic-sam928281@bd3347d.

Caution

Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.


Latta AI seeks to solve problems in open source projects as part of its mission to support developers around the world. Learn more about our mission at https://latta.ai/ourmission . If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants