Skip to content

Commit f071df0

Browse files
authored
Removed dependency on cppzmq (#148)
1 parent cbb440a commit f071df0

File tree

5 files changed

+8
-13
lines changed

5 files changed

+8
-13
lines changed

README.md

+6-7
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ source activate "xeus-cpp"
4040
```
4141
We will now install the dependencies needed to compile xeux-cpp from source within this environment by executing the following
4242
```bash
43-
mamba install notebook cmake cxx-compiler xeus-zmq nlohmann_json=3.11.2 cppzmq xtl jupyterlab CppInterOp cpp-argparse<3.1 pugixml doctest -c conda-forge
43+
mamba install notebook cmake cxx-compiler xeus-zmq nlohmann_json=3.11.3 jupyterlab CppInterOp cpp-argparse<3.1 pugixml doctest -c conda-forge
4444
```
4545
Now you can compile the kernel from the source by executing (replace `$CONDA_PREFIX` with a custom installation prefix if need be)
4646
```bash
@@ -135,16 +135,15 @@ http://xeus-cpp.readthedocs.io
135135

136136
- [xeus-zmq](https://github.com/jupyter-xeus/xeus-zmq)
137137
- [nlohmann_json](https://github.com/nlohmann/json)
138-
- [cppzmq](https://github.com/zeromq/cppzmq)
139138
- [argparse](https://github.com/p-ranav/argparse)
140139
- [CppInterOp](https://github.com/compiler-research/CppInterOp)
141140

142-
| `xeus-cpp` | `xeus-zmq` | `CppInterOp` | `pugixml` | `cppzmq` | `cpp-argparse`| `nlohmann_json` |
143-
|------------|-----------------|--------------|-----------|----------|---------------|-----------------|
144-
| main | >=3.0.0,<4.0.0 | >=1.3.0 | ~1.8.1 | ~4.3.0 | <3.1 | >=3.11.3,<4.0 |
145-
| 0.5.0 | >=3.0.0,<4.0.0 | >=1.3.0 | ~1.8.1 | ~4.3.0 | <3.1 | >=3.11.3,<4.0 |
141+
| `xeus-cpp` | `xeus-zmq` | `CppInterOp` | `pugixml` | `cpp-argparse`| `nlohmann_json` |
142+
|------------|-----------------|--------------|-----------|---------------|-----------------|
143+
| main | >=3.0.0,<4.0.0 | >=1.3.0 | ~1.8.1 | <3.1 | >=3.11.3,<4.0 |
144+
| 0.5.0 | >=3.0.0,<4.0.0 | >=1.3.0 | ~1.8.1 | <3.1 | >=3.11.3,<4.0 |
146145

147-
Versions prior to `0.5.0` have an additional dependency on [xtl](https://github.com/xtensor-stack/xtl) & [clang](https://github.com/llvm/llvm-project/).
146+
Versions prior to `0.5.0` have an additional dependency on [xtl](https://github.com/xtensor-stack/xtl), [clang](https://github.com/llvm/llvm-project/) & [cppzmq](https://github.com/zeromq/cppzmq)
148147

149148
| `xeus-cpp` | `xeus-zmq` | `xtl` | `clang` | `pugixml` | `cppzmq` | `cpp-argparse`| `nlohmann_json` |
150149
|------------|-----------------|-----------------|-----------|-----------|----------|---------------|-----------------|

docs/source/InstallationAndUsage.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ this environment by executing the following
2929

3030
.. code-block:: bash
3131
32-
mamba install notebook cmake cxx-compiler xeus-zmq nlohmann_json=3.11.2 cppzmq
33-
xtl jupyterlab CppInterOp cpp-argparse<3.1 pugixml doctest -c conda-forge
32+
mamba install notebook cmake cxx-compiler xeus-zmq nlohmann_json=3.11.3
33+
jupyterlab CppInterOp cpp-argparse<3.1 pugixml doctest -c conda-forge
3434
3535
Now you can compile the kernel from the source by executing (replace `$CONDA_PREFIX`
3636
with a custom installation prefix if need be)

environment-dev.yml

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ dependencies:
1010
- xeus>=5.0.0
1111
- xeus-zmq>=3.0,<4.0
1212
- nlohmann_json=3.11.3
13-
- cppzmq
1413
- CppInterOp>=1.3.0
1514
- pugixml
1615
- cpp-argparse <3.1

src/main.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ int main(int argc, char* argv[])
6262

6363
interpreter_ptr interpreter = xcpp::build_interpreter(argc, argv);
6464

65-
// auto context = xeus::make_context<zmq::context_t>();
6665
std::unique_ptr<xeus::xcontext> context = xeus::make_zmq_context();
6766

6867
if (!file_name.empty())

xeus-cppConfig.cmake.in

-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR};${CMAKE_MODULE_PATH}")
2222

2323
include(CMakeFindDependencyMacro)
2424
find_dependency(xeus-zmq @xeus-zmq_REQUIRED_VERSION@)
25-
find_dependency(cppzmq @cppzmq_REQUIRED_VERSION@)
26-
2725

2826
if (NOT TARGET xeus-cpp AND NOT TARGET xeus-cpp-static)
2927
include("${CMAKE_CURRENT_LIST_DIR}/@[email protected]")

0 commit comments

Comments
 (0)