Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checksums #2

Open
jonathanong opened this issue Jan 18, 2014 · 3 comments
Open

checksums #2

jonathanong opened this issue Jan 18, 2014 · 3 comments

Comments

@jonathanong
Copy link
Contributor

we currently don't do any checksums on github files. to do so, we would have to get the sha1s of every file in a separate API request (i.e. the tree), which is going to be slow. would be nice if github added a checksum to every raw request.

@tj
Copy link

tj commented Jan 18, 2014

yea that would be nice, we also get ratelimited with the API :(. working on the registry some more tonight

@jonathanong
Copy link
Contributor Author

yeah it's not that bad since it's only 1 api call per repo and you've got 5k an hour. unless you use all the components it shouldn't be a problem. but it's an extra .5 seconds per component!

@tj
Copy link

tj commented Jan 18, 2014

becomes an issue with CI etc, I've definitely hit it even just indexing component.io but I should have the registry up and running this weekend unless something comes up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants