Optimize DatabaseSpecificTrait::escapeIdentifier

Composite PHP · Composite PHP · commit 7efbe27d9bfa · 2023-12-25T10:22:12.000Z
diff --git a/src/Helpers/DatabaseSpecificTrait.php b/src/Helpers/DatabaseSpecificTrait.php
@@ -52,7 +52,11 @@ protected function escapeIdentifier(string $key): string
     {
         $this->identifyPlatform();
         if ($this->isMySQL) {
-            return implode('.', array_map(fn ($part) => "`$part`", explode('.', $key)));
+            if (strpos($key, '.')) {
+                return implode('.', array_map(fn ($part) => "`$part`", explode('.', $key)));
+            } else {
+                return "`$key`";
+            }
         } else {
             return '"' . $key . '"';
         }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,11 @@ protected function escapeIdentifier(string $key): string`
`52`	`52`	`{`
`53`	`53`	`$this->identifyPlatform();`
`54`	`54`	`if ($this->isMySQL) {`
`55`		- return implode('.', array_map(fn ($part) => "`$part`", explode('.', $key)));
	`55`	`+ if (strpos($key, '.')) {`
	`56`	+ return implode('.', array_map(fn ($part) => "`$part`", explode('.', $key)));
	`57`	`+ } else {`
	`58`	+ return "`$key`";
	`59`	`+ }`
`56`	`60`	`} else {`
`57`	`61`	`return '"' . $key . '"';`
`58`	`62`	`}`