Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to cleanup the workdir on workers startup for deployments #373

Open
david-baylibre opened this issue Feb 6, 2025 · 0 comments · May be fixed by #374
Open

Make it possible to cleanup the workdir on workers startup for deployments #373

david-baylibre opened this issue Feb 6, 2025 · 0 comments · May be fixed by #374
Labels
enhancement New feature or request

Comments

@david-baylibre
Copy link

Is your feature request related to a problem? Please describe.

Hi,
The variable worker.cleanUpWorkDirOnStart makes it possible to cleanup the workdir on workers startup but it's been implemented for statefulset only. Is there any good reason it's not implemented in deployments?

Nodes disk space keeps growing up because of unreleased disk space after a worker crashes, gets restarted or even upgraded.
Some may have good reasons for not using statefulsets: local high performance disks required, workers and nodes autoscaling, etc...

Describe the solution you'd like

I wish the cleanup initContainer was implemented in the worker deployment just like it is for statefulsets

I'd be happy to submit a patch

Describe alternatives you've considered

None that I can think of

Additional context

No response

@david-baylibre david-baylibre added the enhancement New feature or request label Feb 6, 2025
@david-baylibre david-baylibre linked a pull request Feb 6, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant