Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get only checking the first 100 assets in the release. #133

Open
kvmw opened this issue Feb 10, 2025 · 0 comments · May be fixed by #134
Open

Get only checking the first 100 assets in the release. #133

kvmw opened this issue Feb 10, 2025 · 0 comments · May be fixed by #134
Labels

Comments

@kvmw
Copy link

kvmw commented Feb 10, 2025

Describe the bug

When listing the release assets to check them against the globs and download them, only the first 100 release assets are considered.
see the source code here.

Some releases like Bellsoft OpenJDK have more than 100 assets.

Reproduction steps

  1. add a github-release resource for OpenJDK 23
  - name: openjdk-release
    type: github-release
    source:
      owner: bell-sw
      repository: Liberica
      access_token: ((github.token))
      semver_constraint: "~23"
  1. add a glob in get step to download the JRE ( JRE is at the end of the list, not in the first 100 assets).
  - get: openjdk-release
    params:
      globs:
        - "bellsoft-jre*-linux-amd64.tar.gz"
  1. run the pipeline and check that no assets have been downloaded.

Expected behavior

the asset matching the provided glob should have been downloaded.

Additional context

Probably, the pagination should be considered for the listing of assets : https://github.com/google/go-github?tab=readme-ov-file#pagination

@kvmw kvmw added the bug label Feb 10, 2025
@kvmw kvmw linked a pull request Feb 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant