-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Feat/add tardigrade_abaqus_tools #30243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@kbrindley will you comment if you are willing to be a maintainer? |
|
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/tardigrade_abaqus_tools/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19686070960. Examine the logs at this URL for more detail. |
|
I am willing to be a maintainer |
|
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
I want to keep this open. We're waiting for the conda-forge c++ team to review some other pull requests. |
|
@NateAM I left suggestions based on past PRs. Probably the same suggestions apply to the remaining tardigrade PRs. I think it's worth pulling the as-merged feedstock for tardigrade error tools and doing a diff on all remaining "add tardigrade" PRs to staged-recipes. |
|
test failure due to incompatible Python requirements: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1396268&view=logs&jobId=4cabe686-70ae-553a-7fd0-310379f2cbac&j=4cabe686-70ae-553a-7fd0-310379f2cbac&t=6a4fc7c9-c31a-5115-eff9-6479d72b69ff You can see that vector tools built against a single version of Python: https://conda-metadata-app.streamlit.app/?q=conda-forge%2Flinux-64%2Ftardigrade_vector_tools-0.8.7-py312hecca717_0.conda I think we need to update vector tools for Python variants and we'll have to make the same change in all tardigrade packages that have a Python runtime dependence. edit: error tools built against many versions of Python. Not sure why error/vector tools are built differently because error tools doesn't have an explicit Python variant list, either: https://conda-metadata-app.streamlit.app/?q=conda-forge%2Flinux-64%2Ftardigrade_error_tools-0.9.7-py314ha160325_2.conda |
|
@kbrindley sorry for all of the spam you just got. I re-based all of the staged recipe branches because the conda api changed leading to additional changes in |
No worries! I'm still excited about getting these PRs through and the tardigrade stack deployed on conda-forge. |
| host: | ||
| - {{ compiler('cxx') }} | ||
| - libgcc {{ libstdcxx }} # [linux] | ||
| - libstdcxx {{ libstdcxx }} # [linux] |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| - /lib64/librt.so.1 | ||
| - /lib64/libc.so.6 | ||
| - /lib64/libpthread.so.0 | ||
| skip: true # [osx or win] |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| script: | ||
| - set -x | ||
| # Build and install c++ libraries | ||
| - cmake -S . -B build -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=lib |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| - set -x | ||
| - cmake -S . -B build -DCMAKE_BUILD_TYPE=conda-test -DCMAKE_INSTALL_LIBDIR=lib | ||
| - cmake --build build --verbose --parallel 4 | ||
| - ctest --test-dir build --verbose --parallel 4 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| missing_dso_whitelist: | ||
| - /lib64/librt.so.1 | ||
| - /lib64/libc.so.6 | ||
| - /lib64/libpthread.so.0 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Looks like this build failure might be fixed by the vector tools build 2. Recipe will probably continue to fail for other reasons until the recipe is updated. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…ency. sort package lists and update to match upstream
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).