Skip to content

Conversation

@NateAM
Copy link
Contributor

@NateAM NateAM commented Jun 4, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@NateAM
Copy link
Contributor Author

NateAM commented Jun 4, 2025

@kbrindley will you comment if you are willing to be a maintainer?

@NateAM
Copy link
Contributor Author

NateAM commented Jun 4, 2025

Blocked by #30240 and #30241

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/tardigrade_abaqus_tools/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: kbrindley. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jun 4, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tardigrade_abaqus_tools/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/tardigrade_abaqus_tools/meta.yaml:

  • ℹ️ The boost output has been superseded by libboost-python-devel (as of 1.82), which now comes with a run-export (on libboost-python) as well.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19686070960. Examine the logs at this URL for more detail.

@kbrindley
Copy link
Contributor

I am willing to be a maintainer

@stale
Copy link

stale bot commented Nov 4, 2025

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@NateAM
Copy link
Contributor Author

NateAM commented Nov 4, 2025

I want to keep this open. We're waiting for the conda-forge c++ team to review some other pull requests.

@stale stale bot removed the stale will be closed in 30 days label Nov 4, 2025
@kbrindley
Copy link
Contributor

@NateAM I left suggestions based on past PRs. Probably the same suggestions apply to the remaining tardigrade PRs. I think it's worth pulling the as-merged feedstock for tardigrade error tools and doing a diff on all remaining "add tardigrade" PRs to staged-recipes.

@kbrindley
Copy link
Contributor

kbrindley commented Nov 19, 2025

test failure due to incompatible Python requirements: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1396268&view=logs&jobId=4cabe686-70ae-553a-7fd0-310379f2cbac&j=4cabe686-70ae-553a-7fd0-310379f2cbac&t=6a4fc7c9-c31a-5115-eff9-6479d72b69ff

Could not solve for environment specs
The following packages are incompatible
├─ python =3.10 *_cpython is requested and can be installed;
└─ tardigrade_vector_tools >=0.8.7 * is not installable because it requires
   └─ python >=3.12,<3.13.0a0 *, which conflicts with any installable versions previously reported.

You can see that vector tools built against a single version of Python: https://conda-metadata-app.streamlit.app/?q=conda-forge%2Flinux-64%2Ftardigrade_vector_tools-0.8.7-py312hecca717_0.conda

I think we need to update vector tools for Python variants and we'll have to make the same change in all tardigrade packages that have a Python runtime dependence.

edit: error tools built against many versions of Python. Not sure why error/vector tools are built differently because error tools doesn't have an explicit Python variant list, either: https://conda-metadata-app.streamlit.app/?q=conda-forge%2Flinux-64%2Ftardigrade_error_tools-0.9.7-py314ha160325_2.conda

@NateAM
Copy link
Contributor Author

NateAM commented Nov 19, 2025

@kbrindley sorry for all of the spam you just got. I re-based all of the staged recipe branches because the conda api changed leading to additional changes in build-locally.py. I didn't think about the fact that it would kick off all of the CI jobs...

@kbrindley
Copy link
Contributor

@kbrindley sorry for all of the spam you just got. I re-based all of the staged recipe branches because the conda api changed leading to additional changes in build-locally.py. I didn't think about the fact that it would kick off all of the CI jobs...

No worries! I'm still excited about getting these PRs through and the tardigrade stack deployed on conda-forge.

host:
- {{ compiler('cxx') }}
- libgcc {{ libstdcxx }} # [linux]
- libstdcxx {{ libstdcxx }} # [linux]

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

- /lib64/librt.so.1
- /lib64/libc.so.6
- /lib64/libpthread.so.0
skip: true # [osx or win]

This comment was marked as resolved.

script:
- set -x
# Build and install c++ libraries
- cmake -S . -B build -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=lib

This comment was marked as resolved.

This comment was marked as resolved.

- set -x
- cmake -S . -B build -DCMAKE_BUILD_TYPE=conda-test -DCMAKE_INSTALL_LIBDIR=lib
- cmake --build build --verbose --parallel 4
- ctest --test-dir build --verbose --parallel 4

This comment was marked as resolved.

Comment on lines 22 to 25
missing_dso_whitelist:
- /lib64/librt.so.1
- /lib64/libc.so.6
- /lib64/libpthread.so.0

This comment was marked as resolved.

@kbrindley
Copy link
Contributor

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1396268&view=logs&jobId=4cabe686-70ae-553a-7fd0-310379f2cbac&j=4cabe686-70ae-553a-7fd0-310379f2cbac&t=6a4fc7c9-c31a-5115-eff9-6479d72b69ff

Could not solve for environment specs
The following packages are incompatible
├─ python =3.10 *_cpython is requested and can be installed;
└─ tardigrade_vector_tools >=0.8.7 * is not installable because it requires
   └─ python >=3.12,<3.13.0a0 *, which conflicts with any installable versions previously reported.

Looks like this build failure might be fixed by the vector tools build 2. Recipe will probably continue to fail for other reasons until the recipe is updated.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tardigrade_abaqus_tools/meta.yaml) and found it was in an excellent condition.

…ency. sort package lists and update to match upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants