Skip to content

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Mar 20, 2025

Tries out this upstream change to use RMM's CCCL: dmlc/xgboost#11353 ( based on dmlc/xgboost#11351 )

As this feedstock does not currently use RMM, this should help validate the patch retains the unpatched behavior unchanged


Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Make sure RMM's CCCL is picked up by XGBoost when searching. That way
XGBoost is built with the same version of CCCL as RMM uses. This should
avoid any potential compatiblity issues between different CCCL versions.
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ py-xgboost output has some malformed specs:
  • In section host: subpackage_pin _py-xgboost-mutex, libxgboost ==cpu_h_PKG_BUILDNUM
  • In section run: subpackage_pin _py-xgboost-mutex, libxgboost ==cpu_h_PKG_BUILDNUM
    py-xgboost-cpu output has some malformed specs:
  • In section host: `py-xgboost ==cpu_pyh_PKG_BUILDNUM
  • In section run: `py-xgboost ==cpu_pyh_PKG_BUILDNUM
    py-xgboost-gpu output has some malformed specs:
  • In section host: `py-xgboost ==cpu_pyh_PKG_BUILDNUM
  • In section run: `py-xgboost ==cpu_pyh_PKG_BUILDNUM
    xgboost output has some malformed specs:
  • In section host: `py-xgboost ==cpu_pyh_PKG_BUILDNUM
  • In section run: `py-xgboost ==cpu_pyh_PKG_BUILDNUM
    r-xgboost output has some malformed specs:
  • In section host: subpackage_pin _r-xgboost-mutex, libxgboost ==cpu_h_PKG_BUILDNUM
  • In section run: subpackage_pin _r-xgboost-mutex, libxgboost ==cpu_h_PKG_BUILDNUM
    r-xgboost-cpu output has some malformed specs:
  • In section host: `r-xgboost ==cpu_rh*_PKG_BUILDNUM
  • In section run: `r-xgboost ==cpu_rh*_PKG_BUILDNUM
    r-xgboost-gpu output has some malformed specs:
  • In section host: `r-xgboost ==cpu_rh*_PKG_BUILDNUM
  • In section run: r-xgboost =*=cpu_r*h*_PKG_BUILDNUM Requirement spec fields should always be space-separated to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build`.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13964488958. Examine the logs at this URL for more detail.

@jakirkham
Copy link
Member Author

As before this is picking up cccl from the conda-forge package as expected

Snippet below from the Linux ARM CUDA 12.8 build:

-- Found libcudacxx: $PREFIX/lib/cmake/libcudacxx/libcudacxx-config.cmake (found suitable version "2.7.0.0", minimum required is "2.7.0.0")
-- Found Thrust: $PREFIX/lib/cmake/thrust/thrust-config.cmake (found suitable exact version "2.7.0.0")
-- Found CUB: $PREFIX/lib/cmake/cub/cub-config.cmake (found suitable version "2.7.0.0", minimum required is "2.7.0.0")
-- Found CCCL: $PREFIX/lib/cmake/cccl/cccl-config.cmake (found version "2.7.0.0")

IOW the XGBoost patch didn't change anything (as expected)

@jakirkham
Copy link
Member Author

Closing as testing is completed

@jakirkham jakirkham closed this Mar 22, 2025
@jakirkham jakirkham deleted the tst_cf_use_rmm_cccl_patch branch March 22, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants