Update to conda 24.1.2, conda-libmamba-solver 24.1.0, libmambapy 1.5.6 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
|
CI errors fixed in #60 |
jezdez
reviewed
Feb 27, 2024
| - raise DeprecatedError("unable to determine the calling module") from None | ||
| + # raise DeprecatedError("unable to determine the calling module") from None | ||
| + import sys as unknown | ||
| + return (unknown, "<unknown>") |
There was a problem hiding this comment.
I'm not following, why is this needed?
There was a problem hiding this comment.
PyInstaller will fail to determine the module being deprecated because some attribute was missing during the inspection. It was introduced in #25. I'll comment it out to see what happens (maybe we don't need it anymore?), and worst case I can post the traceback for posterity.
|
Well, it works without the patch now :) Can you review @jezdez? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to conda 24.1.2, conda-libmamba-solver 24.1.0, libmambapy 1.5.6
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?