Mark flaky tests

Signed-off-by: apostasie <[email protected]>

Author: apostasie

cmd/nerdctl/container/container_create_linux_test.go

@@ -187,7 +187,11 @@ func TestCreateWithTty(t *testing.T) {
 func TestIssue2993(t *testing.T) {
 	testCase := nerdtest.Setup()
 
-	testCase.Require = test.Not(nerdtest.Docker)
+	testCase.Require = test.Require(
+		test.Not(nerdtest.Docker),
+		// Maybe the use of a custom data root has an impact?
+		nerdtest.IsFlaky("https://github.com/containerd/nerdctl/issues/3518"),
+	)
 
 	const (
 		containersPathKey = "containersPath"

cmd/nerdctl/image/image_history_test.go

@@ -76,6 +76,9 @@ func TestImageHistory(t *testing.T) {
 			test.Not(test.Windows),
 			// XXX Currently, history does not work on non-native platform, so, we cannot test reliably on other platforms
 			test.Arm64,
+			// XXX this here is very likely breaking other tests because of one of the variants of
+			// https://github.com/containerd/nerdctl/issues/3513 so, making it private to try avoid that
+			nerdtest.Private,
 		),
 		Setup: func(data test.Data, helpers test.Helpers) {
 			helpers.Ensure("pull", "--platform", "linux/arm64", testutil.CommonImage)

cmd/nerdctl/image/image_inspect_test.go

@@ -18,6 +18,7 @@ package image
 
 import (
 	"encoding/json"
+	"runtime"
 	"strings"
 	"testing"
 
@@ -35,7 +36,7 @@ func TestImageInspectSimpleCases(t *testing.T) {
 	testCase := &test.Case{
 		Description: "TestImageInspect",
 		Setup: func(data test.Data, helpers test.Helpers) {
-			helpers.Ensure("pull", testutil.CommonImage)
+			helpers.Ensure("pull", "--quiet", testutil.CommonImage)
 		},
 		SubTests: []*test.Case{
 			{
@@ -64,6 +65,10 @@ func TestImageInspectSimpleCases(t *testing.T) {
 		},
 	}
 
+	if runtime.GOOS == "windows" {
+		testCase.Require = nerdtest.IsFlaky("https://github.com/containerd/nerdctl/issues/3524")
+	}
+
 	testCase.Run(t)
 }
 

cmd/nerdctl/image/image_list_test.go

@@ -125,7 +125,10 @@ func TestImagesFilter(t *testing.T) {
 
 	testCase := &test.Case{
 		Description: "TestImagesFilter",
-		Require:     nerdtest.Build,
+		Require: test.Require(
+			nerdtest.Build,
+			nerdtest.IsFlaky("https://github.com/containerd/nerdctl/issues/3512"),
+		),
 		Setup: func(data test.Data, helpers test.Helpers) {
 			helpers.Ensure("pull", testutil.CommonImage)
 			helpers.Ensure("tag", testutil.CommonImage, "taggedimage:one-fragment-one")

cmd/nerdctl/image/image_save_test.go

@@ -19,6 +19,7 @@ package image
 import (
 	"os"
 	"path/filepath"
+	"runtime"
 	"strings"
 	"testing"
 
@@ -70,6 +71,10 @@ func TestSave(t *testing.T) {
 	// See https://github.com/containerd/nerdctl/issues/3425 and others for details.
 	testCase.Require = nerdtest.Private
 
+	if runtime.GOOS == "windows" {
+		testCase.Require = test.Require(testCase.Require, nerdtest.IsFlaky("https://github.com/containerd/nerdctl/issues/3524"))
+	}
+
 	testCase.SubTests = []*test.Case{
 		{
 			Description: "Single image, by id",

cmd/nerdctl/ipfs/ipfs_compose_linux_test.go

@@ -46,6 +46,7 @@ func TestIPFSCompNoBuild(t *testing.T) {
 		test.Not(nerdtest.Docker),
 		nerdtest.Registry,
 		nerdtest.IPFS,
+		nerdtest.IsFlaky("https://github.com/containerd/nerdctl/issues/3510"),
 		// See note below
 		// nerdtest.Private,
 	)