Skip to content

Commit 2fc84d7

Browse files
committed
Mark flaky tests
Signed-off-by: apostasie <[email protected]>
1 parent 49049c1 commit 2fc84d7

File tree

4 files changed

+13
-0
lines changed

4 files changed

+13
-0
lines changed

cmd/nerdctl/container/container_logs_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ func TestLogsOutStreamsSeparated(t *testing.T) {
8282
}
8383

8484
func TestLogsWithInheritedFlags(t *testing.T) {
85+
// Seen flaky with Docker
8586
t.Parallel()
8687
base := testutil.NewBase(t)
8788
for k, v := range base.Args {

cmd/nerdctl/image/image_inspect_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package image
1818

1919
import (
2020
"encoding/json"
21+
"runtime"
2122
"strings"
2223
"testing"
2324

@@ -64,6 +65,10 @@ func TestImageInspectSimpleCases(t *testing.T) {
6465
},
6566
}
6667

68+
if runtime.GOOS == "windows" {
69+
testCase.Require = nerdtest.IsFlaky("https://github.com/containerd/nerdctl/issues/3524")
70+
}
71+
6772
testCase.Run(t)
6873
}
6974

cmd/nerdctl/image/image_save_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package image
1919
import (
2020
"os"
2121
"path/filepath"
22+
"runtime"
2223
"strings"
2324
"testing"
2425

@@ -70,6 +71,10 @@ func TestSave(t *testing.T) {
7071
// See https://github.com/containerd/nerdctl/issues/3425 and others for details.
7172
testCase.Require = nerdtest.Private
7273

74+
if runtime.GOOS == "windows" {
75+
testCase.Require = nerdtest.IsFlaky("https://github.com/containerd/nerdctl/issues/3524")
76+
}
77+
7378
testCase.SubTests = []*test.Case{
7479
{
7580
Description: "Single image, by id",

cmd/nerdctl/ipfs/ipfs_compose_linux_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ func TestIPFSCompNoBuild(t *testing.T) {
4646
test.Not(nerdtest.Docker),
4747
nerdtest.Registry,
4848
nerdtest.IPFS,
49+
nerdtest.IsFlaky("https://github.com/containerd/nerdctl/issues/3510"),
4950
// See note below
5051
// nerdtest.Private,
5152
)
@@ -152,6 +153,7 @@ services:
152153
WORDPRESS_DB_USER: exampleuser
153154
WORDPRESS_DB_PASSWORD: examplepass
154155
WORDPRESS_DB_NAME: exampledb
156+
# FIXME: this is flaky and will make the container fail on occasions
155157
volumes:
156158
- wordpress:/var/www/html
157159

0 commit comments

Comments
 (0)