Merge pull request #3300 from apostasie/dev-compose-tty

Fix panic when stdout is not a tty

Author: AkihiroSuda

cmd/nerdctl/compose_exec.go

@@ -18,7 +18,9 @@ package main
 
 import (
 	"errors"
+	"os"
 
+	"github.com/moby/term"
 	"github.com/spf13/cobra"
 
 	"github.com/containerd/nerdctl/v2/pkg/clientutil"
@@ -37,7 +39,8 @@ func newComposeExecCommand() *cobra.Command {
 	}
 	composeExecCommand.Flags().SetInterspersed(false)
 
-	composeExecCommand.Flags().BoolP("no-TTY", "T", false, "Disable pseudo-TTY allocation. By default nerdctl compose exec allocates a TTY.")
+	_, isTerminal := term.GetFdInfo(os.Stdout)
+	composeExecCommand.Flags().BoolP("no-TTY", "T", !isTerminal, "Disable pseudo-TTY allocation. By default nerdctl compose exec allocates a TTY.")
 	composeExecCommand.Flags().BoolP("detach", "d", false, "Detached mode: Run containers in the background")
 	composeExecCommand.Flags().StringP("workdir", "w", "", "Working directory inside the container")
 	// env needs to be StringArray, not StringSlice, to prevent "FOO=foo1,foo2" from being split to {"FOO=foo1", "foo2"}

cmd/nerdctl/container_exec.go

@@ -18,7 +18,9 @@ package main
 
 import (
 	"errors"
+	"os"
 
+	"github.com/moby/term"
 	"github.com/spf13/cobra"
 
 	containerd "github.com/containerd/containerd/v2/client"
@@ -84,6 +86,13 @@ func processExecCommandOptions(cmd *cobra.Command) (types.ContainerExecOptions,
 		}
 	}
 
+	_, isTerminal := term.GetFdInfo(os.Stdin)
+	if !flagD {
+		if flagT && flagI && !isTerminal {
+			return types.ContainerExecOptions{}, errors.New("the input device is not a TTY")
+		}
+	}
+
 	workdir, err := cmd.Flags().GetString("workdir")
 	if err != nil {
 		return types.ContainerExecOptions{}, err