filterRange() in NetteDatabaseTableDataSource ignored the number zero (#1144)

PavelWeirich · Pavel W · web-flow · commit 568d45940f97 · 2024-08-23T11:10:19.000+02:00
Co-authored-by: Pavel W &lt;pavel.weirich@makeart.cz&gt;
diff --git a/src/DataSource/NetteDatabaseTableDataSource.php b/src/DataSource/NetteDatabaseTableDataSource.php
@@ -177,11 +177,11 @@ protected function applyFilterRange(FilterRange $filter): void
 		$valueFrom = $conditions[$filter->getColumn()]['from'];
 		$valueTo = $conditions[$filter->getColumn()]['to'];
 
-		if ($valueFrom) {
+		if ($valueFrom !== '') {
 			$this->dataSource->where(sprintf('%s >= ?', $filter->getColumn()), $valueFrom);
 		}
 
-		if ($valueTo) {
+		if ($valueTo !== '') {
 			$this->dataSource->where(sprintf('%s <= ?', $filter->getColumn()), $valueTo);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -177,11 +177,11 @@ protected function applyFilterRange(FilterRange $filter): void`
`177`	`177`	`$valueFrom = $conditions[$filter->getColumn()]['from'];`
`178`	`178`	`$valueTo = $conditions[$filter->getColumn()]['to'];`
`179`	`179`
`180`		`- if ($valueFrom) {`
	`180`	`+ if ($valueFrom !== '') {`
`181`	`181`	`$this->dataSource->where(sprintf('%s >= ?', $filter->getColumn()), $valueFrom);`
`182`	`182`	`}`
`183`	`183`
`184`		`- if ($valueTo) {`
	`184`	`+ if ($valueTo !== '') {`
`185`	`185`	`$this->dataSource->where(sprintf('%s <= ?', $filter->getColumn()), $valueTo);`
`186`	`186`	`}`
`187`	`187`	`}`