Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributte/di extended but not required in composer #10

Closed
finwe opened this issue Feb 11, 2024 · 4 comments
Closed

contributte/di extended but not required in composer #10

finwe opened this issue Feb 11, 2024 · 4 comments

Comments

@finwe
Copy link
Contributor

finwe commented Feb 11, 2024

When installed per documentation in a plain nette project, compiling the DI container ends with Class "Contributte\DI\Extension\CompilerExtension" not found as contributte/di is not required in the package require composer.json section.

@finwe
Copy link
Contributor Author

finwe commented Feb 11, 2024

Can prepare a PR if adding the library is the preferred solution. Which version should be required?

@f3l1x
Copy link
Member

f3l1x commented Feb 13, 2024

Please drop contributte/di usage, thank you.

@finwe
Copy link
Contributor Author

finwe commented Feb 13, 2024

@f3l1x I'm not sure I understand correctly. Should I stop using contributte/di, or add contributte/di to composer.json, and if so, which version? :)

@f3l1x
Copy link
Member

f3l1x commented Feb 13, 2024

I mean, remove Contributte\DI\Extension\CompilerExtension and extends from nette/di directly.

finwe added a commit to finwe/contributte-messenger that referenced this issue Feb 13, 2024
finwe added a commit to finwe/contributte-messenger that referenced this issue Feb 13, 2024
@f3l1x f3l1x closed this as completed in dd1d4eb Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants