From d72f85b0bdc4ca2dc0a93e270f3b2b56e9157f4f Mon Sep 17 00:00:00 2001 From: binh-dam-ibigroup <56846598+binh-dam-ibigroup@users.noreply.github.com> Date: Thu, 25 Mar 2021 18:18:55 -0400 Subject: [PATCH 1/2] ci(node-ci.yml): Fix criterion to execute storybook deploy. --- .github/workflows/node-ci.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml index 26cdbb3..e9c368d 100644 --- a/.github/workflows/node-ci.yml +++ b/.github/workflows/node-ci.yml @@ -9,10 +9,7 @@ on: jobs: test-build-release: env: - GIT_BRANCH_NAME: ${{ github.ref }} - IS_PUSH: ${{ github.event_name }} - IS_PUSH_TO_MASTER: ${{ github.event.push && github.ref == 'refs/heads/master' }} - IS_PUSH_TO_MASTER_ALT: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }} + IS_PUSH_TO_MASTER: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }} runs-on: ubuntu-latest From 21af51ab0235e576bb8453625ce0cb85fd1f4a56 Mon Sep 17 00:00:00 2001 From: binh-dam-ibigroup <56846598+binh-dam-ibigroup@users.noreply.github.com> Date: Fri, 26 Mar 2021 10:36:01 -0400 Subject: [PATCH 2/2] ci(node-ci.yml): Investigate https://s3..amazonaws.com path error. --- .github/workflows/node-ci.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml index e9c368d..6c03415 100644 --- a/.github/workflows/node-ci.yml +++ b/.github/workflows/node-ci.yml @@ -50,5 +50,5 @@ jobs: # Deploy storybook demo to S3 if handling a push (non-PR build) on the main branch # https://s3.amazonaws.com/transitive.js/index.html - name: Deploy storybook to S3 - if: ${{ env.IS_PUSH_TO_MASTER }} + if: ${{ env.IS_PUSH_TO_MASTER == true }} run: yarn deploy-storybook diff --git a/package.json b/package.json index 5625061..0195b96 100644 --- a/package.json +++ b/package.json @@ -32,7 +32,7 @@ "lint": "mastarm lint lib", "semantic-release": "semantic-release", "start": "start-storybook -p 5555", - "deploy-storybook": "storybook-to-aws-s3 --bucket-path=transitive.js --s3-sync-options=--acl=public-read" + "deploy-storybook": "storybook-to-aws-s3 --bucket-path=bdam-testbuckt --s3-sync-options=--acl=public-read" }, "devDependencies": { "@babel/core": "^7.12.3",