Merge pull request #72 from conveyal/typescript

Add TypeScript, replace mastarm with tsdx

Author: binh-dam-ibigroup

.babelrc

@@ -0,0 +1,111 @@
+// this file was autogenerated by tsdx using the `yarn lint --write-file` command
+module.exports = {
+  "extends": [
+    "standard",
+    "standard-jsx",
+    "react-app",
+    "plugin:@typescript-eslint/recommended",
+    "plugin:react/recommended",
+    "plugin:jest/recommended",
+    "plugin:jsx-a11y/strict",
+    "plugin:prettier/recommended",
+    "prettier"
+  ],
+  "parser": "@typescript-eslint/parser",
+  "plugins": [
+    "@typescript-eslint",
+    "sort-keys-fix",
+    "import",
+    "jest",
+    "jsx-a11y",
+    "react",
+    "sort-destructure-keys"
+  ],
+  "rules": {
+    "@typescript-eslint/member-delimiter-style": [
+      "off",
+      {
+        "multiline": {
+          "delimiter": "none",
+          "requireLast": false
+        },
+        "singleline": {
+          "delimiter": "comma",
+          "requireLast": false
+        }
+      }
+    ],
+    "@typescript-eslint/no-var-requires": 0,
+    "complexity": [
+      "warn",
+      12
+    ],
+    "import/order": [
+      "warn",
+      {
+        "newlines-between": "always"
+      }
+    ],
+    "jsx-a11y/label-has-for": [
+      2,
+      {
+        "allowChildren": false,
+        "components": [
+          "Label"
+        ],
+        "required": {
+          "every": [
+            "id"
+          ]
+        }
+      }
+    ],
+    "object-curly-spacing": 0,
+    "prefer-const": [
+      "warn",
+      {
+        "destructuring": "all",
+        "ignoreReadBeforeAssign": false
+      }
+    ],
+    "prettier/prettier": [
+      "error",
+      {
+        "semi": false,
+        "singleQuote": true,
+        "trailingComma": "none"
+      }
+    ],
+    "react/jsx-sort-props": [
+      "error",
+      {
+        "ignoreCase": true
+      }
+    ],
+    "sort-destructure-keys/sort-destructure-keys": [
+      "error",
+      {
+        "caseSensitive": false
+      }
+    ],
+    "sort-keys": [
+      "error",
+      "asc",
+      {
+        "caseSensitive": false
+      }
+    ],
+    "sort-keys-fix/sort-keys-fix": "warn",
+    "sort-vars": [
+      "error",
+      {
+        "ignoreCase": true
+      }
+    ]
+  },
+  "settings": {
+    "react": {
+      "version": "detect"
+    }
+  }
+}

.eslintrc.js

@@ -21,18 +21,20 @@ jobs:
           node-version: 12.x
       - name: Install npm packages using cache
         uses: bahmutov/npm-install@v1
+        with:
+          # the IBI Group TSDX fork has some dependency issues
+          # that cause yarn install to fail on a ci runner. Disabling
+          # concurrency allows installation to complete successfully
+          install-command: yarn --frozen-lockfile --network-concurrency 1
       - name: Lint code
         run: yarn lint
       - name: Run tests with coverage
         run: yarn cover
 
       # at this point, the build is successful
-      - name: Codecov
-        uses: codecov/[email protected]
-        continue-on-error: true
       - name: Semantic Release
         env:
-          GH_TOKEN: ${{ secrets.GH_TOKEN }}
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
         run: yarn semantic-release
 

.github/workflows/node-ci.yml

@@ -15,6 +15,7 @@ logs
 results
 
 build
+dist
 node_modules
 components
 npm-debug.log

.gitignore

@@ -1,17 +1,4 @@
-const path = require('path')
-// your app's webpack.config.js
-const custom = require('./webpack.config.js');
-
 module.exports = {
-  stories: ['../stories/*.stories.js'],
-  addons: [
-    '@storybook/addon-links',
-    '@storybook/addon-essentials',
-    '@storybook/preset-create-react-app'
-  ],
-  // Ensures that, when running storybook, webpack rules (loaders for css, file,
-  // etc.) from the custom config are used.
-  webpackFinal: (config) => {
-    return { ...config, module: { ...config.module, rules: custom.module.rules } };
-  }
+  addons: ['@storybook/addon-links', '@storybook/addon-essentials'],
+  stories: ['../stories/*.stories.js']
 }

.storybook/main.js

@@ -1,6 +1,6 @@
 /* globals describe, expect, it */
 
-import {addVectors} from '../../lib/util'
+import { addVectors } from '../../lib/util'
 
 describe('util', () => {
   it('addVectors should work', () => {