From abf818b90eef960a139f29e08efcec7f678fcda3 Mon Sep 17 00:00:00 2001 From: Agent X <44549182+AgentXLP@users.noreply.github.com> Date: Fri, 14 Feb 2025 18:42:41 -0500 Subject: [PATCH] Boy what the hell (unbreak mods and DynOS packs) They dug me out of my grave and told me `configSkipPackGeneration`. My heart sank. This feature would have been fine if it was off by default and if it wasn't then people caught it before the version was officially released and the option was promptly disabled without a massive pool of people having this option turned on by default. So I will say, Coolio wasn't really in the wrong by adding this, it should have never been changed to be on by default. --- data/dynos_bin_col.cpp | 2 +- data/dynos_gfx_init.cpp | 2 -- src/pc/configfile.c | 2 -- src/pc/configfile.h | 1 - 4 files changed, 1 insertion(+), 6 deletions(-) diff --git a/data/dynos_bin_col.cpp b/data/dynos_bin_col.cpp index cebc98cae..5501fc7be 100644 --- a/data/dynos_bin_col.cpp +++ b/data/dynos_bin_col.cpp @@ -53,7 +53,7 @@ static void ValidateColSectionChange(GfxData* aGfxData, struct CollisionValidati PrintDataError("Improper triangle count found in section. Allocated: %u, Defined: %u", aColValData.triAlloc, aColValData.triCount); } if (aColValData.specialAlloc != aColValData.specialCount) { - PrintDataError("Improper sepcial count found in section. Allocated: %u, Defined: %u", aColValData.triAlloc, aColValData.triCount); + PrintDataError("Improper special count found in section. Allocated: %u, Defined: %u", aColValData.triAlloc, aColValData.triCount); } if (aColValData.waterBoxAlloc != aColValData.waterBoxCount) { PrintDataError("Improper water box count found in section. Allocated: %u, Defined: %u", aColValData.waterBoxAlloc, aColValData.waterBoxCount); diff --git a/data/dynos_gfx_init.cpp b/data/dynos_gfx_init.cpp index 3e4ac2145..3fbae797c 100644 --- a/data/dynos_gfx_init.cpp +++ b/data/dynos_gfx_init.cpp @@ -4,8 +4,6 @@ extern "C" { } void DynOS_Gfx_GeneratePacks(const char* directory) { - if (configSkipPackGeneration) { return; } - LOADING_SCREEN_MUTEX( loading_screen_reset_progress_bar(); snprintf(gCurrLoadingSegment.str, 256, "Generating DynOS Packs In Path:\n\\#808080\\%s", directory); diff --git a/src/pc/configfile.c b/src/pc/configfile.c index 134361fc9..8f781bff1 100644 --- a/src/pc/configfile.c +++ b/src/pc/configfile.c @@ -188,7 +188,6 @@ unsigned int configDjuiScale = 0; // other unsigned int configRulesVersion = 0; bool configCompressOnStartup = false; -bool configSkipPackGeneration = true; // secrets bool configExCoopTheme = false; @@ -320,7 +319,6 @@ static const struct ConfigOption options[] = { // other {.name = "rules_version", .type = CONFIG_TYPE_UINT, .uintValue = &configRulesVersion}, {.name = "compress_on_startup", .type = CONFIG_TYPE_BOOL, .boolValue = &configCompressOnStartup}, - {.name = "skip_pack_generation", .type = CONFIG_TYPE_BOOL, .boolValue = &configSkipPackGeneration}, }; struct SecretConfigOption { diff --git a/src/pc/configfile.h b/src/pc/configfile.h index cbefa1f39..046d898bc 100644 --- a/src/pc/configfile.h +++ b/src/pc/configfile.h @@ -137,7 +137,6 @@ extern unsigned int configDjuiScale; // other extern unsigned int configRulesVersion; extern bool configCompressOnStartup; -extern bool configSkipPackGeneration; // secrets extern bool configExCoopTheme;