Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring test coverage to 100% #87

Closed
gr2m opened this issue Sep 13, 2024 · 3 comments · Fixed by #107
Closed

Bring test coverage to 100% #87

gr2m opened this issue Sep 13, 2024 · 3 comments · Fixed by #107
Labels
maintenance pull request welcome Issue is actionable and anyone can claim it released

Comments

@gr2m
Copy link
Collaborator

gr2m commented Sep 13, 2024

Now that we have test coverage enabled via #86 thanks to @artifactz1, we can address the parts of the code that are not yet covered and do so. Where applicable, lines or branches can also be ignored, see syntax
@gr2m gr2m added pull request welcome Issue is actionable and anyone can claim it maintenance labels Sep 13, 2024
@oscard0m
Copy link
Contributor

oscard0m commented Sep 17, 2024 •
edited
Loading

I'm working on this!

This was referenced Sep 17, 2024
Merged
Merged
francisfuzz pushed a commit that referenced this issue Sep 18, 2024
@oscard0m
test(parse): add test coverage when no copilot_confirmations present (#…
bcf306b 
…100)

<!--
This pull request template provides suggested sections for framing your
work.
You're welcome to change or remove headers if it doesn't fit your use
case. :)
-->

### What are you trying to accomplish?
Improve test coverage for `parse.js` file. Concretely for
`getUserConfirmation()` method.

relates to
#87
@gr2m
Copy link
Collaborator Author

gr2m commented Sep 18, 2024

yoooo @oscard0m so nice to see you contribute ❤

gr2m pushed a commit that referenced this issue Sep 18, 2024
@oscard0m
test(verification): improve test coverage for `verifyRequestByKeyId()…
7914799 
…` and `fetchVerificationKeys()` (#101)

### What are you trying to accomplish?
Improve test coverage for `verification.js` file. Concretely for
`verifyRequestByKeyId()` and `fetchVerificationKeys()` methods.

relates to
#87
This was referenced Sep 18, 2024
Merged
Merged
gr2m pushed a commit that referenced this issue Sep 18, 2024
@oscard0m
test(verification): add coverage for fetchVerificationKeys() on err…
7ca71ee 
…or (#105)

<!--
This pull request template provides suggested sections for framing your
work.
You're welcome to change or remove headers if it doesn't fit your use
case. :)
-->

### What are you trying to accomplish?
Improve test coverage for `verification.js`

### Context
Relates to #87
gr2m pushed a commit that referenced this issue Sep 18, 2024
@oscard0m
test(prompt): improve test coverage for prompt.js (#104)
ab45116 
### What are you trying to accomplish?
- **test(prompt): add 100% test coverage for `parsePromptArguments()`**
- **test(prompt): add test coverage for prompt.stream()**

### Context
Relates to #87 
<!--
This pull request template provides suggested sections for framing your
work.
You're welcome to change or remove headers if it doesn't fit your use
case. :)

### What are you trying to accomplish?

### What approach did you choose and why?

### What should reviewers focus on?
-->
@oscard0m oscard0m mentioned this issue Sep 18, 2024
Merged
@gr2m gr2m closed this as completed in #107 Sep 18, 2024
@gr2m gr2m closed this as completed in f5e17c3 Sep 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024

🎉 This issue has been resolved in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance pull request welcome Issue is actionable and anyone can claim it released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(test): require a test coverage of 100% in CI oscard0m/preview-sdk.js
2 participants
@gr2m @oscard0m