Link to package homepage instead of the No Docs warning while we add … (#64)

* Link to package "doc" field or homepage instead of the No Docs warning while we add support for doc linking

* Fix test-suite

Author: mattam82

src/rocqproverorg_frontend/layouts/package_layout.eml

@@ -60,19 +60,20 @@ Layout.base
             <li class="flex flex-auto">
               <a class="w-full h-10 flex justify-center rounded-r-lg p-1 items-center font-semibold border border-l-0  border-primary dark:border-dark-primary <%s (match path with | Documentation _ -> "bg-primary dark:bg-dark-primary text-white dark:text-dark-title" | _ -> "text-primary dark:text-dark-primary bg-sand dark:bg-dark-card")%>" href="<%s Url.Package.documentation package.name ?version:(Package.url_version package) %>">Docs</a>
             </li>
-            <% | Unknown -> ( %>
+            <% | _ ->
+              let title, link = match package.Package.doc with
+                | Some doc -> "Doc", doc
+                | None -> match package.Package.homepages with
+                  | [] -> "No Docs", ""
+                  | hd :: _ -> "Homepage", hd
+              in
+            %>
             <li class="flex flex-auto">
-              <span aria-label="Documentation status is unknown" class="w-full h-10 flex justify-center gap-2 rounded-r-lg p-1 items-center font-semibold border border-l-0 border-separator_20 dark:border-dark-separator_30 <%s (match path with | Documentation _ -> "bg-primary dark:bg-dark-primary text-title dark:text-dark-title" | _ -> "text-title dark:text-dark-title bg-sand dark:bg-dark-card")%>"><%s! Icons.error "" %> No Docs</span>
+              <a class="w-full h-10 flex justify-center rounded-r-lg p-1 items-center font-semibold border border-l-0  border-primary dark:border-dark-primary <%s (match path with | Documentation _ -> "bg-primary dark:bg-dark-primary text-white dark:text-dark-title" | _ -> "text-primary dark:text-dark-primary bg-sand dark:bg-dark-card")%>" href="<%s link %>"><%s title %></a>
             </li>
-            <% )
-            | Failure -> ( %>
-            <li class="flex flex-auto">
-              <a title="Documentation failed to build!" class="w-full h-10 flex justify-center gap-2 rounded-r-lg p-1 items-center font-semibold border border-l-0  border-gray-400 <%s (match path with | Documentation _ -> "bg-primary text-white" | _ -> "text-gray-500 bg-sand")%>" href="<%s Url.Package.documentation package.name ?version:(Package.url_version package) %>"><%s! Icons.error "" %> No Docs</a>
-            </li>
-            <% ));%>
+            <% ); %>
           </li>
         </ol>
-
         <div id="in-package-search" class="relative w-full">
           <div class="flex w-full items-center overflow-hidden">
             <% if Option.is_some search_index_digest then (%>

src/rocqproverorg_frontend/package.ml

@@ -16,6 +16,7 @@ type package = {
   maintainers : Data.Opam_user.t list;
   publication : float;
   homepages : string list;
+  doc: string option; 
   source : (string * string list) option;
       (* TODO: these should be part of package.json coming from voodoo, but they
          currently aren't

src/rocqproverorg_package/lib/info.ml

@@ -11,6 +11,7 @@ type t = {
   maintainers : string list;
   license : string;
   homepage : string list;
+  doc : string option;
   tags : string list;
   dependencies : (OpamPackage.Name.t * string option) list;
   rev_deps : (OpamPackage.Name.t * string option * OpamPackage.Version.t) list;
@@ -152,6 +153,7 @@ let make ~package ~packages ~rev_deps ~timestamps opam =
     description =
       descr opam |> Option.map OpamFile.Descr.body |> Option.value ~default:"";
     homepage = homepage opam;
+    doc = List.nth_opt (doc opam) 0;
     tags = tags opam;
     rev_deps;
     conflicts = get_conflicts opam;

src/rocqproverorg_package/lib/rocqproverorg_package.mli

@@ -40,6 +40,7 @@ module Info : sig
     maintainers : string list;
     license : string;
     homepage : string list;
+    doc : string option;
     tags : string list;
     dependencies : (Name.t * string option) list;
     rev_deps : (Name.t * string option * Version.t) list;

src/rocqproverorg_web/lib/handler.ml

@@ -797,6 +797,7 @@ module Package_helper = struct
         license = info.license;
         publication = info.publication;
         homepages = info.Rocqproverorg_package.Info.homepage;
+        doc = info.Rocqproverorg_package.Info.doc;
         source =
           Option.map
             (fun url ->

src/rocqproverorg_web/test/graphql_test.ml

@@ -19,6 +19,7 @@ let empty_info =
     maintainers = [];
     license = "";
     homepage = [];
+    doc = None;
     tags = [];
     dependencies;
     rev_deps = [];