Skip to content

Commit 57eb8c6

Browse files
authored
Merge pull request #49 from coreofscience/update-ci-stuffs
Update deploy instructions
2 parents 121fa8e + bad4f13 commit 57eb8c6

10 files changed

+32
-108
lines changed

.firebaserc

+22
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
{
2+
"projects": {
3+
"prod": "coreofscience",
4+
"dev": "coreofscience-dev"
5+
},
6+
"targets": {
7+
"coreofscience-dev": {
8+
"hosting": {
9+
"tos": [
10+
"tos-coreofscience-dev"
11+
]
12+
}
13+
},
14+
"coreofscience": {
15+
"hosting": {
16+
"tos": [
17+
"tos-coreofscience-prod-7f714"
18+
]
19+
}
20+
}
21+
}
22+
}

.github/workflows/deploy-dev-site.yml

+4-16
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Build and Deploy
1+
name: Build and Deploy Dev Site
22

33
on:
44
push:
@@ -19,25 +19,13 @@ jobs:
1919
with:
2020
node-version: 14.x
2121

22-
- name: Install dependencies
23-
run: npm ci
24-
env:
25-
CI: true
26-
2722
- name: Build
2823
run: |
24+
npm ci
2925
npm run build
30-
cat << EOF > .firebaserc
31-
{
32-
"projects": {
33-
"default": "coreofscience-dev"
34-
}
35-
}
36-
EOF
37-
npm run firebase -- target:apply hosting tos tos-coreofscience-dev
3826
env:
3927
CI: true
40-
REACT_APP_APIKEY: ${{ secrets.DEV_API_KEY }}
28+
REACT_APP_APIKEY: ${{ secrets.FIREBASE_WEB_API_KEY_DEV }}
4129
REACT_APP_AUTHDOMAIN: "coreofscience-dev.firebaseapp.com"
4230
REACT_APP_DATABASEURL: "https://coreofscience-dev.firebaseio.com"
4331
REACT_APP_PROJECTID: "coreofscience-dev"
@@ -49,4 +37,4 @@ jobs:
4937
- name: Deploy
5038
run: |
5139
npm install firebase-tools
52-
npm run deploy -- --token=${{ secrets.FIREBASE_TOKEN }} -P coreofscience-dev
40+
npm run deploy -- --token=${{ secrets.FIREBASE_TOKEN }} -P dev

.github/workflows/deploy-preview.yml

+2-14
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ name: Deploy to Preview Channel
22

33
on:
44
pull_request:
5-
# Optionally configure to run only for specific files. For example:
6-
# paths:
7-
# - "website/**"
85

96
jobs:
107
build_and_preview:
@@ -15,18 +12,9 @@ jobs:
1512
- run: |
1613
npm ci
1714
npm run build
18-
# Firebase use --alias doesn't work
19-
cat << EOF > .firebaserc
20-
{
21-
"projects": {
22-
"default": "coreofscience-dev"
23-
}
24-
}
25-
EOF
26-
npm run firebase -- target:apply hosting tos tos-coreofscience-dev
2715
env:
2816
CI: true
29-
REACT_APP_APIKEY: ${{ secrets.DEV_API_KEY }}
17+
REACT_APP_APIKEY: ${{ secrets.FIREBASE_WEB_API_KEY_DEV }}
3018
REACT_APP_AUTHDOMAIN: "coreofscience-dev.firebaseapp.com"
3119
REACT_APP_DATABASEURL: "https://coreofscience-dev.firebaseio.com"
3220
REACT_APP_PROJECTID: "coreofscience-dev"
@@ -40,6 +28,6 @@ jobs:
4028
repoToken: "${{ secrets.GITHUB_TOKEN }}"
4129
firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT }}"
4230
expires: 30d
43-
projectId: coreofscience-dev
31+
projectId: dev
4432
env:
4533
FIREBASE_CLI_PREVIEWS: hostingchannels

.github/workflows/deploy-prod-site.yml

+3-15
Original file line numberDiff line numberDiff line change
@@ -19,25 +19,13 @@ jobs:
1919
with:
2020
node-version: 14.x
2121

22-
- name: Install dependencies
23-
run: npm ci
24-
env:
25-
CI: true
26-
2722
- name: Build
2823
run: |
24+
npm ci
2925
npm run build
30-
cat << EOF > .firebaserc
31-
{
32-
"projects": {
33-
"default": "coreofscience"
34-
}
35-
}
36-
EOF
37-
npm run firebase -- target:apply hosting tos tos-coreofscience-prod-7f714
3826
env:
3927
CI: true
40-
REACT_APP_APIKEY: ${{ secrets.PROD_API_KEY }}
28+
REACT_APP_APIKEY: ${{ secrets.FIREBASE_WEB_API_KEY_PROD }}
4129
REACT_APP_AUTHDOMAIN: "coreofscience.firebaseapp.com"
4230
REACT_APP_DATABASEURL: "https://coreofscience.firebaseio.com"
4331
REACT_APP_PROJECTID: "coreofscience"
@@ -49,4 +37,4 @@ jobs:
4937
- name: Deploy
5038
run: |
5139
npm install firebase-tools
52-
npm run deploy -- --token=${{ secrets.FIREBASE_TOKEN }} -P coreofscience
40+
npm run deploy -- --token=${{ secrets.FIREBASE_TOKEN }} -P prod

.gitignore

+1-2
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,5 @@ yarn-error.log*
3131
.env.*
3232

3333
# Firebase
34-
.firebaserc
3534
.firebase
36-
firebase-debug.log
35+
firebase-debug.log

firebase.json

-10
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
11
{
2-
"database": {
3-
"rules": "./firebase/database.rules.json"
4-
},
5-
"storage": {
6-
"rules": "./firebase/storage.rules"
7-
},
82
"hosting": {
93
"target": "tos",
104
"public": "build",
@@ -15,9 +9,5 @@
159
"destination": "/index.html"
1610
}
1711
]
18-
},
19-
"firestore": {
20-
"rules": "./firebase/firestore.rules",
21-
"indexes": "./firebase/firestore.indexes.json"
2212
}
2313
}

firebase/database.rules.json

-20
This file was deleted.

firebase/firestore.indexes.json

-4
This file was deleted.

firebase/firestore.rules

-16
This file was deleted.

firebase/storage.rules

-11
This file was deleted.

0 commit comments

Comments
 (0)