fix params in CTE (#79)

* custom parameters all seem to be working, still have a few more tests to write

* fix numeric and custom tokens

* fix linting and test for old node

* all tests working again

* some linting complaints, oops

* add test for overriding defaults

* lints ugh

* return unknown type if not param

* adhere to spec for default params

* remove obsolete test

* test and a possible fix

the fix just adds any CTE params to the next statement, but I'm not sure
how I feel about that

* run linting and remove .only

Author: not-night-but

src/parser.ts

@@ -164,12 +164,14 @@ export function parse(
     statementEnd: boolean;
     parens: 0;
     state: State;
+    params: Array<string>;
   } = {
     isCte: false,
     asSeen: false,
     statementEnd: false,
     parens: 0,
     state: topLevelState,
+    params: [],
   };
 
   const ignoreOutsideBlankTokens = ['whitespace', 'comment-inline', 'comment-block', 'semicolon'];
@@ -251,11 +253,17 @@ export function parse(
         if (cteState.isCte) {
           statementParser.getStatement().start = cteState.state.start;
           statementParser.getStatement().isCte = true;
+          statementParser.getStatement().parameters.push(...cteState.params);
+          cteState.params = [];
           cteState.isCte = false;
           cteState.asSeen = false;
           cteState.statementEnd = false;
         }
       }
+
+      if (cteState.isCte && token.type === 'parameter') {
+        cteState.params.push(token.value);
+      }
     } else {
       statementParser.addToken(token, nextToken);
       topLevelStatement.tokens.push(token);

test/index.spec.ts

@@ -66,6 +66,27 @@ describe('identify', () => {
     ]);
   });
 
+  it('params should be recognized in a CTE', () => {
+    const query = `
+      WITH foo AS (
+        SELECT * FROM bar where user_id = $1::bigint
+      )
+      SELECT * FROM foo
+    `;
+
+    expect(identify(query.trim(), { dialect: 'psql' })).to.eql([
+      {
+        start: 0,
+        end: 97,
+        text: query.trim(),
+        type: 'SELECT',
+        executionType: 'LISTING',
+        parameters: ['$1'],
+        tables: [],
+      },
+    ]);
+  });
+
   it('should identify tables in simple for basic cases', () => {
     expect(
       identify('SELECT * FROM foo JOIN bar ON foo.id = bar.id', { identifyTables: true }),