Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default for strict to false #38

Open
MasterOdin opened this issue Jul 23, 2021 · 1 comment
Open

Set default for strict to false #38

MasterOdin opened this issue Jul 23, 2021 · 1 comment

Comments

@MasterOdin
Copy link
Member

In both sqlectron and beekeeper-studio, it looks like we pretty universally use sql-query-identifier with strict: false. I propose just making that the default as it's probably the better behavior than throwing an exception in the context of analyzing it before running it, especially given that this library does not implement a true AST for the supported dialects. Can put this in v3 which would contain the breaking change discussed in #33 (comment).

Thoughts @rathboma?

@rathboma
Copy link
Contributor

Yes! Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants